Open maryamariyan opened 3 years ago
Tagging subscribers to this area: @maryamariyan See info in area-owners.md if you want to be subscribed.
Author: | maryamariyan |
---|---|
Assignees: | - |
Labels: | `api-suggestion`, `area-Extensions-Logging` |
Milestone: | - |
@tarekgh any update on this, please?
We couldn't get into this yet because we are occupied with other high-priority tasks.
Background and Motivation
As part of .NET 6 we updated the new
LoggerMessage.Define
overloads to useLogDefineOptions
. (PR here and issue https://github.com/dotnet/runtime/issues/50913)Later in .NET 7, for supporting more arguments, we could add a new
Define<T>
API (where T is a delegate) that would take n arguments, log level, event ID, format string andLogDefineOptions
to log message.Theoretically we need an analyzer that makes sure the arguments of the new Define API are proper (ILogger etc.). The source generator would not be using the new Define (where T is delegate) API. (not source gen friendly).
We welcome API proposals! We have a process to evaluate the value and shape of new API. There is an overview of our process . This template will help us gather the information we need to start the review process. First, please describe the purpose and value of the new API here.
Proposed API
Something like:
T
would be a delegate but an analyzer would need to make sure it takes ILogger, Exception, etc.System.Action<Microsoft.Extensions.Logging.ILogger, T1, T2, ..., Tn, System.Exception?>
TODO
cc: @davidfowl @eerhardt