search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.26k stars 4.73k forks source link

Build failed: Validate-DotNet/main real signed, .NET 6, validation-runtime-.NET 6, runtime #runtime-101520-.NET6 #57259

Closed dotnet-eng-status[bot] closed 11 months ago

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-101520-.NET6 partiallySucceeded

:warning: : internal / Validate-DotNet partiallySucceeded

Summary

Finished - Thu, 12 Aug 2021 03:27:59 GMT Duration - 259 minutes Requested for - DotNet Bot Reason - manual

Details

Validation Ring

Required Validation Ring

Source Code Validation

Changes

ericstj commented 3 years ago

Code that generates that command is here: https://github.com/dotnet/runtime/blob/74ba1330fa5dbdc084493cdae014a69431bdaa6b/src/workloads/workloads.csproj#L166

I don't see anything that stands out. It's getting all the wixobj and it's passing the util extension. @mmitche @joeloff is it possible it's not using the latest wix drop? That could cause it.

michellemcdaniel commented 3 years ago

I also recently made a change to SignTool. Checking to make sure that that change wasn't the cause.

joeloff commented 3 years ago

The error looks odd though, is it complaining about the license (RTF) file? That should just be a statically linked file.

mmitche commented 3 years ago

The error looks odd though, is it complaining about the license (RTF) file? That should just be a statically linked file.

No, that's not an error, it's just an informational that there wasn't a signed file that needed replacing in the original container (because this isn't signed).

mmitche commented 3 years ago

Here's the actual error:

D:\a\_work\1\s\artifacts\obj\workloads\src\msi\Microsoft.NETCore.App.Runtime.Mono.android-arm\6.0.0-rtm.21508.16\x64\dotnethome_x64.wxs(24) : error LGHT0094 : Unresolved reference to symbol 'Property:WIX_NATIVE_MACHINE' in section 'Fragment:'.

It most likely means that one of the input files required to repack the msi is not being gathered up in CreateLightCommandPackageDrop

joeloff commented 3 years ago

That property comes from WiXCA. It could be missing a link option. That's defined in the new build of WiX 3.14.0.5722 we're using.

ericstj commented 3 years ago

It could be missing a link option.

I checked for that and it looks like the extension is passed in: https://github.com/dotnet/runtime/blob/74ba1330fa5dbdc084493cdae014a69431bdaa6b/src/workloads/workloads.csproj#L175 My guess is that it's using an old wix toolset. @mmitche can you see what version of wix it is using?

michellemcdaniel commented 3 years ago

We are using whatever version is specified in arcade. The version of SignTool/Arcade Sdk in the release repo is 7.0.0-beta.21508.1, so up-to-date as of Friday.

ericstj commented 3 years ago

Here's the commit which made the update in 7.0 https://github.com/dotnet/arcade/commit/feb3b11cc9eb78eee2759136273f4c3721fcb93a

Here's the one for 6.0 https://github.com/dotnet/arcade/commit/ee8d37dc8994143757d3948348ac66b7b9f736a6

Both would have been present. I would hope this is using 6.0 tools since it's a 6.0 build, can you double check the version? Can you share any more of the commandline / log from the failure? Wherever @mmitche got that error from would be good to see. It's important to see the light.exe its running and where it came from, as well as the commandline passed in.

ViktorHofer commented 3 years ago

In case it helps, I think this is also happening in main based on the corresponding validation issue: https://github.com/dotnet/runtime/issues/57892#issuecomment-939624063.

michellemcdaniel commented 3 years ago

They all run off the same branch, so that makes sense.

ericstj commented 3 years ago

So I chatted with @mmitche offline. He's seeing that error when reproducing locally, using build 1.0.0-v3.14.0.4118 of wix, which makes sense, that build doesn't have the feature we are depending on. We need 1.0.0-v3.14.5772. I double checked the commandline from the zip that the build is using and it includes -ext WixUtilExtension so we are referencing the component which defines this property, just missing the feature from the build of wix that's being used.

We need to get the release tools using the same build of WiX as arcade/runtime. @mmitche says this won't happen until Wednesday due to it being dotnet-release repo. I'll let him explain more.

michellemcdaniel commented 3 years ago

I guess I'm confused. The validation pipeline is run off of the main branch of dotnet-release, not the production branch. That means that it has the latest version of arcade that the repo has, and the latest version of arcade has 1.0.0-v3.14.5772 of wix, according to the commit history, which means that this was built using the correct WiX version.

ericstj commented 3 years ago

The signing tool appears to be repackaging Wix itself: https://dev.azure.com/dnceng/internal/_git/dotnet-release?path=/src/Microsoft.DotNet.Release/Microsoft.DotNet.Signing.Extensions/Microsoft.DotNet.Signing.Extensions.csproj&version=GBmain&line=4&lineEnd=5&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

It appears that's lagging because the SharedFramework SDK is almost a year old: https://dev.azure.com/dnceng/internal/_git/dotnet-release?path=/global.json&version=GBmain&line=13&lineEnd=14&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

michellemcdaniel commented 3 years ago

Thanks. I'll look to see if I can get the sharedframework sdk updated.

edit: remove the reference and convert over to Microsoft.DotNet.Build.Task.Installers

michellemcdaniel commented 3 years ago

I created https://github.com/dotnet/arcade/issues/8022. @mmitche is also working on fixing this, so it sounds like we may be doing duplicate work. He has more indepth knowledge of the project, so I will likely let him take care of this.

mmitche commented 3 years ago

https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/18878

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-113464-.NET6 partiallySucceeded

:warning: : internal / Validate-DotNet partiallySucceeded

Summary

Finished - Tue, 12 Oct 2021 04:31:28 GMT Duration - 322 minutes Requested for - DotNet Bot Reason - manual

Details

Validation Ring

Source Code Validation

Changes

ViktorHofer commented 3 years ago

This helped and that specific error is gone 🎉🎉🎉. Unfortunately we are now seeing a few missing symbols from random packages.

ViktorHofer commented 3 years ago

@adiaaida @mmitche I'm skeptical that the missing symbols in the last run are actionable by us. Is this https://github.com/dotnet/arcade/issues/8015?

michellemcdaniel commented 3 years ago

Could be. @epananth

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-113794-.NET6 partiallySucceeded

:warning: : internal / Validate-DotNet partiallySucceeded

Summary

Finished - Wed, 13 Oct 2021 04:43:27 GMT Duration - 337 minutes Requested for - DotNet Bot Reason - manual

Details

Validation Ring

Source Code Validation

Changes

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-113934-.NET6 partiallySucceeded

:warning: : internal / Validate-DotNet partiallySucceeded

Summary

Finished - Thu, 14 Oct 2021 04:29:34 GMT Duration - 322 minutes Requested for - DotNet Bot Reason - manual

Details

Validation Ring

Source Code Validation

Changes

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-114325-.NET6 partiallySucceeded

:warning: : internal / Validate-DotNet partiallySucceeded

Summary

Finished - Fri, 15 Oct 2021 03:23:15 GMT Duration - 257 minutes Requested for - DotNet Bot Reason - manual

Details

Validation Ring

Source Code Validation

Changes

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-114591-.NET6 partiallySucceeded

:warning: : internal / Validate-DotNet partiallySucceeded

Summary

Finished - Sat, 16 Oct 2021 03:40:46 GMT Duration - 273 minutes Requested for - DotNet Bot Reason - manual

Details

Validation Ring

Signing Ring

Source Code Validation

Changes

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-114681-.NET6 partiallySucceeded

:warning: : internal / Validate-DotNet partiallySucceeded

Summary

Finished - Sun, 17 Oct 2021 03:39:54 GMT Duration - 274 minutes Requested for - DotNet Bot Reason - manual

Details

Validation Ring

Source Code Validation

Changes

michellemcdaniel commented 3 years ago

@epananth's change for symbols validation has gone in, so we are no longer seeing the symbols validation failures (since those files are excluded): https://dev.azure.com/dnceng/internal/_build/results?buildId=1428519&view=results. Going to close this and the .NET 7 issue (assuming all are ok with that).

ViktorHofer commented 3 years ago

We are still seeing the "Source Code Validation" issues that @aik-jahoda is working on fixing. Let's keep this and the 7.0 issue open until those are fixed as well.

michellemcdaniel commented 3 years ago

I'm also working on that from an infra standpoint. If what the Guardian folks gave me works, I should have a PR out to you guys this afternoon.

ViktorHofer commented 3 years ago

That is fantastic to hear 👍

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-115490-.NET6 failed

:x: : internal / Validate-DotNet failed

Summary

Finished - Thu, 21 Oct 2021 00:05:59 GMT Duration - 60 minutes Requested for - DotNet Bot Reason - manual

Details

Signing Ring

Source Code Validation

Prep Ring

Changes

michellemcdaniel commented 3 years ago

The signing error likely means that something is going wrong in publishing, but I’ll check out the gather drop log in the morning

michellemcdaniel commented 3 years ago

I think we are getting the version wrong again @mmitche

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-115706-.NET6 failed

:x: : internal / Validate-DotNet failed

Summary

Finished - Fri, 22 Oct 2021 00:04:08 GMT Duration - 56 minutes Requested for - DotNet Bot Reason - manual

Details

Signing Ring

Source Code Validation

Prep Ring

Changes

dotnet-eng-status[bot] commented 3 years ago

Build #runtime-115940-.NET6 failed

:x: : internal / Validate-DotNet failed

Summary

Finished - Sun, 24 Oct 2021 03:15:47 GMT Duration - 249 minutes Requested for - DotNet Bot Reason - manual

Details

Validation Ring

Source Code Validation

Changes

aik-jahoda commented 3 years ago

@ViktorHofer I believe all credscan issues are gone. The credscan tool was updated and new discovered bugs were fixed.

dotnet-eng-status[bot] commented 2 years ago

Build #runtime-117789-.NET6 failed

:x: : internal / Validate-DotNet failed

Summary

Finished - Thu, 11 Nov 2021 05:47:15 GMT Duration - 400 minutes Requested for - DotNet Bot Reason - manual

Details

Validation Ring

Source Code Validation

Changes

michellemcdaniel commented 2 years ago

I have a PR here to increase sourcelink validation timeout here: https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/19783

akoeplinger commented 11 months ago

Doesn't look like this is relevant anymore, closing.