dotnet-issue-labeler[bot]
commented
2 years ago I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.
Closed runfoapp[bot] closed 2 years ago
dotnet-issue-labeler[bot]
commented
2 years ago I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.
ghost
commented
2 years ago Tagging subscribers to this area: @dotnet/area-system-reflection See info in area-owners.md if you want to be subscribed.
| Author: | runfoapp[bot] |
|---|---|
| Assignees: | - |
| Labels: | `area-System.Reflection`, `untriaged` |
| Milestone: | - |
AaronRobinsonMSFT
commented
2 years ago This is causing consistent issues across the repo. I am currently investigating on macOS.
AaronRobinsonMSFT
commented
2 years ago Still building. Here are the known parts.
1) The test:
[Fact]
[SkipOnMono("Nullability attributes trimmed on Mono")]
public void NullablePublicOnlyOtherTypesTest()
{
Type type = typeof(Type);
FieldInfo privateNullableField = type.GetField("s_defaultBinder", flags)!;
NullabilityInfo info = nullabilityContext.Create(privateNullableField); // <------ Failing here2) The value should exist on Type.
public static Binder DefaultBinder
{
get
{
if (s_defaultBinder == null)
{
DefaultBinder binder = new DefaultBinder();
Interlocked.CompareExchange<Binder?>(ref s_defaultBinder, binder, null);
}
return s_defaultBinder!;
}
}
private static volatile Binder? s_defaultBinder;My only guess here is the trimmer might have done something? I was assured the trimmer should not run in this case, but I don't see how else this test would fail as follows:
System.Reflection.Tests.NullabilityInfoContextTests.NullablePublicOnlyOtherTypesTest [FAIL]
System.ArgumentNullException : Value cannot be null. (Parameter 'fieldInfo')
Stack Trace:
at <PrivateImplementationDetails>.Throw(String paramName)
at <PrivateImplementationDetails>.ThrowIfNull(Object argument, String paramName)
at System.Reflection.NullabilityInfoContext.Create(FieldInfo fieldInfo)
/_/src/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs(763,0): at System.Reflection.Tests.NullabilityInfoContextTests.NullablePublicOnlyOtherTypesTest()
elinor-fung
commented
2 years ago I think this is actually from https://github.com/dotnet/runtime/pull/65986, which removed the _code field from Regex
cc @stephentoub
AaronRobinsonMSFT
commented
2 years ago @elinor-fung Hmmm. I must have missed something but based on the stack you must be correct. I am still unable to reproduce this locally though.
Edit: I'm officially wearing the dunce hat today... I'm able to reproduce this locally and see the issue now.
stephentoub
commented
2 years ago I think this is actually from https://github.com/dotnet/runtime/pull/65986, which removed the _code field from Regex
Ugh. I'll fix it. We shouldn't be relying on private fields like this across test suites :(
stephentoub
commented
2 years ago This should be fixed by #66113
Displaying 100 of 191 results