Open buyaa-n opened 2 years ago
/cc @SamMonoRT
@naricc - this was another case of a disabled test still run in CI
Update or possibly not.
This is going to affect https://github.com/dotnet/runtime/issues/70133 if the proposal lands with [MarshalAs<JSType.Number>]
-style attributes
The assertion is only in ref-emit custom attribute code - so generic custom attributes in regular c# files might be ok?
And specifically for [MarshalAs<T>]
, it wouldn't be Mono looking at the attributes, it would be the source generator.
So this is worth fixing, but it's not a blocker for the JS marshaller work
Moving to 9.0.0, we'll consider a backport based on the actual fix.
Mono is crashing on the newly added tests even though they were disabled on Mono:
To unblock the PR the failing tests are commented out https://github.com/dotnet/runtime/blob/0bfa71cc6331f9fc4be45a531447d4c0ec97134a/src/tests/reflection/GenericAttribute/GenericAttributeTests.cs#L21-L30
Originally posted by @jkotas in https://github.com/dotnet/runtime/issues/65237#issuecomment-1041935039
More logs
link