dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.14k stars 4.71k forks source link

Fix triple slash exceptions on `BlockingCollection.Take()` method #66374

Open carlossanlop opened 2 years ago

carlossanlop commented 2 years ago

As discussed here: https://github.com/dotnet/dotnet-api-docs/pull/7807/files#r822224919

ghost commented 2 years ago

Tagging subscribers to this area: @dotnet/area-system-collections See info in area-owners.md if you want to be subscribed.

Issue Details
As discussed here: https://github.com/dotnet/dotnet-api-docs/pull/7807/files#r822224919 - `OperationCanceledException` should be removed since the `Take()` overload. Only the `Take(CancelationToken)` overlos throws that exception. - The `InvalidOperationException` should be updated to match what we have in dotnet-api-docs (make sure to fix it in both `Take` overloads if necessary): https://github.com/dotnet/dotnet-api-docs/blob/d67c461d2960e0c3fffe94dc30fb6751f8bd33e4/xml/System.Collections.Concurrent/BlockingCollection%601.xml#L1406
Author: carlossanlop
Assignees: -
Labels: `documentation`, `area-System.Collections`
Milestone: -