Closed performanceautofiler[bot] closed 2 years ago
Can be one of https://github.com/dotnet/runtime/pull/66432, https://github.com/dotnet/runtime/pull/66339 or https://github.com/dotnet/runtime/pull/66363 cc @stephentoub
Based on the specific pattern, it would almost certainly be the switch to use StartsWith(..., OrdinalIgnoreCase) (https://github.com/dotnet/runtime/pull/66339), since this pattern would have us doing a comparison against 7 different strings case-insensitive. @EgorBo, is your change to lift the inlining/unrolling limit reflected here?
@stephentoub if it's StartsWith
we need to wait a couple of days to see if https://github.com/dotnet/runtime/pull/66534 helped (https://pvscmdupload.blob.core.windows.net/reports/allTestHistory%2frefs%2fheads%2fmain_arm64_Windows%2010.0.19041%2fSystem.Text.RegularExpressions.Tests.Perf_Regex_Industry_RustLang_Sherlock.Count(Pattern%3a%20%22(%3fi)Sherlock%7cHolmes%7cWatson%22%2c%20Options%3a%20Compiled).html).
It worth noting that my PR to inline StartsWith
handles only up to 16 chars for arm64 where we don't have Vector256. But I have a small patch that extended that up to 64 chars for hot blocks (will file a PR this weekend)
Tagging subscribers to this area: @dotnet/area-system-text-json See info in area-owners.md if you want to be subscribed.
Author: | performanceautofiler[bot] |
---|---|
Assignees: | - |
Labels: | `area-System.Text.Json`, `untriaged`, `refs/heads/main`, `RunKind=micro`, `Windows 10.0.19041`, `Regression`, `CoreClr`, `arm64` |
Milestone: | - |
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions See info in area-owners.md if you want to be subscribed.
Author: | performanceautofiler[bot] |
---|---|
Assignees: | - |
Labels: | `area-System.Text.RegularExpressions`, `untriaged`, `refs/heads/main`, `RunKind=micro`, `Windows 10.0.19041`, `Regression`, `CoreClr`, `arm64` |
Milestone: | - |
arm64 is a redundant label, it can be deleted (I've updated the two issues it was assigned to).
I deleted the label. These things pop up when issues are ported to this repo I believe.
The regression is gone.
Run Information
Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_RustLang_Sherlock
Test Report
Repro