Open Wraith2 opened 2 years ago
Tagging subscribers to this area: @vitek-karas, @agocke, @vsadov See info in area-owners.md if you want to be subscribed.
Author: | Wraith2 |
---|---|
Assignees: | - |
Labels: | `area-Host`, `untriaged` |
Milestone: | - |
@VSadov @jkoritzinsky would one of you know something about this? It seems that when the "Checked" configuration is specified, we build the host as "Debug", but then packaging expects to find it in "Checked" directories.
@Wraith2 just curious what is the scenario to build everything as "Checked"? I agree that it should either work or explicitly fail, but it would be interesting to know what you want to use the output for...
I tinker with the jit codebase and a checked build is needed for spmi. building the entire repo is easier than trying to work out and mash together the individual parts that are needed from debug and release builds.
I tinker with the jit codebase and a checked build is needed for spmi.
For that prehaps it's better to use checked only for runtime configuration and debug (or release) for everything else. i.e.
build -c Debug -rc Checked
or build -c Release -rc Checked
I'll give that a try.
The original issue still remains though, something broke those packages in the last week which means changes are being made that break stuff and aren't being seen.
Using build -c Release -rc Checked
also has problems:
...
E:\Programming\csharp7\runtime\artifacts\obj\Microsoft.NETCore.App.Host\Release\net7.0\win-x64\output/ -> E:\Programming\csharp7\runtime\artifacts\packages\Release\Shipping\/dotnet-apphost-pack-7.0.0-dev-win-x64.zip
Successfully created package 'E:\Programming\csharp7\runtime\artifacts\packages\Release\Shipping\Microsoft.NETCore.App.Host.win-x64.7.0.0-dev.nupkg'.
Successfully created package 'E:\Programming\csharp7\runtime\artifacts\packages\Release\Shipping\Microsoft.NETCore.App.Host.win-x64.7.0.0-dev.symbols.nupkg'.
Microsoft.NETCore.App.Crossgen2 ->
Zipping directory "E:\Programming\csharp7\runtime\artifacts\obj\Microsoft.NETCore.App.Crossgen2\Release\net7.0\win-x64\output\" to "E:\Programming\csharp7\runtime\artifacts\packages\Release\Shipping\dotnet-crossgen2-7.0.0-dev-win-x64.zip".
E:\Programming\csharp7\runtime\artifacts\obj\Microsoft.NETCore.App.Crossgen2\Release\net7.0\win-x64\output/ -> E:\Programming\csharp7\runtime\artifacts\packages\Release\Shipping\/dotnet-crossgen2-7.0.0-dev-win-x64.zip
Successfully created package 'E:\Programming\csharp7\runtime\artifacts\packages\Release\Shipping\Microsoft.NETCore.App.Crossgen2.win-x64.7.0.0-dev.nupkg'.
C:\Program Files\dotnet\sdk\6.0.102\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): error NU5118: File 'E:\Programming\csharp7\runtime\artifacts\bin\coreclr\windows.x64.Checked\PDB\crossgen2.pdb' is not added because the package already contains file 'runtimes\win-x64\lib\net7.0\..\..\..\..\tools\crossgen2.pdb' [E:\Programming\csharp7\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.sfxproj]
C:\Program Files\dotnet\sdk\6.0.102\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): error NU5118: File 'E:\Programming\csharp7\runtime\artifacts\bin\coreclr\windows.x64.Checked\PDB\ILCompiler.DependencyAnalysisFramework.pdb' is not added because the package already contains file 'runtimes\win-x64\lib\net7.0\..\..\..\..\tools\ILCompiler.DependencyAnalysisFramework.pdb' [E:\Programming\csharp7\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.sfxproj]
C:\Program Files\dotnet\sdk\6.0.102\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): error NU5118: File 'E:\Programming\csharp7\runtime\artifacts\bin\coreclr\windows.x64.Checked\PDB\ILCompiler.Diagnostics.pdb' is not added because the package already contains file 'runtimes\win-x64\lib\net7.0\..\..\..\..\tools\ILCompiler.Diagnostics.pdb' [E:\Programming\csharp7\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.sfxproj]C:\Program Files\dotnet\sdk\6.0.102\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): error NU5118: File 'E:\Programming\csharp7\runtime\artifacts\bin\coreclr\windows.x64.Checked\PDB\ILCompiler.ReadyToRun.pdb' is not added because the package already contains file 'runtimes\win-x64\lib\net7.0\..\..\..\..\tools\ILCompiler.ReadyToRun.pdb' [E:\Programming\csharp7\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.sfxproj]
C:\Program Files\dotnet\sdk\6.0.102\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): error NU5118: File 'E:\Programming\csharp7\runtime\artifacts\bin\coreclr\windows.x64.Checked\PDB\ILCompiler.TypeSystem.pdb' is not added because the package already contains file 'runtimes\win-x64\lib\net7.0\..\..\..\..\tools\ILCompiler.TypeSystem.pdb' [E:\Programming\csharp7\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.sfxproj]
Successfully created package 'E:\Programming\csharp7\runtime\artifacts\packages\Release\Shipping\Microsoft.NETCore.App.Crossgen2.win-x64.7.0.0-dev.symbols.nupkg'.
If it wasn't from a completely clean build, the NU5118
errors might be https://github.com/dotnet/runtime/issues/62918.
If it wasn't from a completely clean build, the
NU5118
errors might be #62918.
Perhaps, but in order for a release or checked build to succeed you must first run a clean debug build so there is no ability to run a clean checked build. However if it's fixed under another issue that's ok.
Tagging subscribers to this area: @hoyosjs See info in area-owners.md if you want to be subscribed.
Author: | Wraith2 |
---|---|
Assignees: | - |
Labels: | `area-Infrastructure-coreclr` |
Milestone: | - |
Description
The Debug build succeeds, restores all the things needed for builds etc. The checked build fails to create nuget packages. Except from the end of the log:
Reproduction Steps
commands to reproduce from runtime root:
git clean -xdf
build && build -c Checked
Expected behavior
Build should succeed.
Actual behavior
Build fails.
Regression?
No response
Known Workarounds
No response
Configuration
No response
Other information
No response