Closed performanceautofiler[bot] closed 1 year ago
Tagging subscribers to this area: @JulieLeeMSFT See info in area-owners.md if you want to be subscribed.
Author: | performanceautofiler[bot] |
---|---|
Assignees: | - |
Labels: | `area-CodeGen-coreclr`, `untriaged`, `refs/heads/main`, `ubuntu 18.04`, `RunKind=micro`, `PGO`, `Regression`, `CoreClr`, `arm64` |
Milestone: | - |
Utf8 Encoding: None of our PGO training scenarios reach these code paths and so they aren't well optimized.
Related windows arm64 regressions https://github.com/dotnet/perf-autofiling-issues/issues/4730
@EgorBo if you are going to add non EN US PGO coverage, I would hope we'd see improvements here.
looks like https://github.com/dotnet/runtime/pull/68055
Looking at the charts linked above, it looks like this regression was fixed around August 5th. Does anyone know what fixed the problem, and did that fix make it into RC2? The rc2 vs 6.0 perf report indicates that the regression is still present to some extent.
Suspect it might have been this change: https://github.com/dotnet/runtime/pull/73973 where we updated the PGO training scenarios to cover other locales and added arm64 coverage.
Hard to tell exactly when because we had big outage right around then.
These do indeed seem to be fixed (though a few regressed again around 9/25), so closing. Random sampling:
As of the 7 vs 6 report, it seems like this regression might still be present on Mac Arm64 configs. Could the fix have missed the 7.0 cutoff?
It's possible that PGO is simply not applied for any OSX (and the fix is in the PGO)
Closing this since we've now enabled dynamic PGO (and spot checking, perf for these cases looks good).
Run Information
Regressions in System.Collections.ContainsFalse<Int32>
Test Report
Repro
Run Information
Regressions in System.Text.Perf_Utf8Encoding
Test Report
Repro
Run Information
Regressions in System.Collections.IndexerSetReverse<Int32>
Test Report
Repro
category:performance theme:benchmarks