search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.42k stars 4.76k forks source link

Reenable assert for a case when mapping an R2R PE failed on OSX #68873

Open VSadov opened 2 years ago

VSadov commented 2 years ago

We have a fallback mechanism, but using it implies that PE does not meet expectations of our loader. That is suspicious and typically means there is a bug either in the tool that produced the PE or in the loader.

https://github.com/dotnet/runtime/pull/68845 has suppressed the assert on OSX temporarely. The change fixes a bug that could trigger this assert, but it will take some time for the fix to propagate to SDK and to published builds, so for now the assert is disabled on OSX.

Should be reenabled at some time in the future.

ghost commented 2 years ago

Tagging subscribers to this area: @agocke, @vitek-karas, @vsadov See info in area-owners.md if you want to be subscribed.

Issue Details
We have a fallback mechanism, but using it implies that PE does not meet expectations of our loader. That is suspicious and typically means there is a bug either in the tool that produced the PE or in the loader. https://github.com/dotnet/runtime/pull/68845 has suppressed the assert on OSX temporarely. The change fixes a bug that could trigger this assert, but it will take some time for the fix to propagate to SDK and to published builds, so for now the assert is disabled on OSX. Should be reenabled at some time in the future.
Author: VSadov
Assignees: VSadov
Labels: `area-Single-File`
Milestone: -
VSadov commented 1 year ago

Since we are not running installer tests on OSX in debug/checked, the value in enabling this for 8.0 is not very high. I will move this to 9.0