search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.27k stars 4.73k forks source link

System.IO.Tests.directory_move_multiple_from_watched_to_unwatched_mac test failing #70164

Open runfoapp[bot] opened 2 years ago

runfoapp[bot] commented 2 years ago
Runfo Tracking Issue: directory_move_multiple_from_watched_to_unwatched_mac test failing Build Definition Kind Run Name
Build Result Summary Day Hit Count Week Hit Count Month Hit Count
0 0 0
dotnet-issue-labeler[bot] commented 2 years ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ghost commented 2 years ago

Tagging subscribers to this area: @dotnet/area-system-io See info in area-owners.md if you want to be subscribed.

Issue Details
Runfo Tracking Issue: [directory_move_multiple_from_watched_to_unwatched_mac test failing](https://runfo.azurewebsites.net/tracking/issue/339) |Build|Definition|Kind|Run Name|Console|Core Dump|Test Results|Run Client| |---|---|---|---|---|---|---|---| |[1802244](https://dev.azure.com/dnceng/public/_build/results?buildId=1802244)|[runtime](https://dnceng.visualstudio.com/public/_build?definitionId=686)|Rolling|net7.0-OSX-Release-x64-CoreCLR_checked-OSX.1200.Amd64.Open|[console.log](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-3a5a9c549b6748c592/System.IO.FileSystem.Watcher.Tests/1/console.52454293.log?%3F%253Fhelixlogtype%253Dresult)|||[runclient.py](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-3a5a9c549b6748c592/System.IO.FileSystem.Watcher.Tests/d8f5b85f-825f-4935-9d40-50348332bd82.log?%3F%253Fhelixlogtype%253Dresult)| |[1802244](https://dev.azure.com/dnceng/public/_build/results?buildId=1802244)|[runtime](https://dnceng.visualstudio.com/public/_build?definitionId=686)|Rolling|net7.0-OSX-Release-x64-CoreCLR_checked-OSX.1200.Amd64.Open|[console.log](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-3a5a9c549b6748c592/System.IO.FileSystem.Watcher.Tests/1/console.52454293.log?%3F%253Fhelixlogtype%253Dresult)|||[runclient.py](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-3a5a9c549b6748c592/System.IO.FileSystem.Watcher.Tests/d8f5b85f-825f-4935-9d40-50348332bd82.log?%3F%253Fhelixlogtype%253Dresult)| Build Result Summary |Day Hit Count|Week Hit Count|Month Hit Count| |---|---|---| |1|1|1|
Author: runfoapp[bot]
Assignees: -
Labels: `area-System.IO`, `blocking-clean-ci`
Milestone: -
agocke commented 2 years ago

This one just started failing recently, possibly a product issue

danmoseley commented 2 years ago 
    System.IO.Tests.Directory_Move_Tests.Directory_Move_Multiple_From_Watched_To_Unwatched_Mac(filesCount: 1) [FAIL]
      Assert.Equal() Failure
                 ↓ (pos 0)
      Expected: [Deleted /tmp/helix/working/A81808FC/t/#Di···
      Actual:   []
                 ↑ (pos 0)
      Stack Trace:
        /_/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs(183,0): at System.IO.Tests.Directory_Move_Tests.DirectoryMove_Multiple_FromWatchedToUnwatched(Int32 filesCount, Boolean skipOldEvents)
        /_/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs(37,0): at System.IO.Tests.Directory_Move_Tests.Directory_Move_Multiple_From_Watched_To_Unwatched_Mac(Int32 filesCount)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
maraf commented 2 years ago

Similar test failed on yesterday's rolling build #20220606.1 (console log).

System.IO.Tests.File_Move_Tests.File_Move_Multiple_From_Watched_To_Unwatched_Mac(filesCount: 1) [FAIL]
      Assert.Equal() Failure
                 ↓ (pos 0)
      Expected: [Deleted /tmp/helix/working/B7240A1B/t/#Fi···
      Actual:   []
                 ↑ (pos 0)
      Stack Trace:
        /_/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs(237,0): at System.IO.Tests.File_Move_Tests.FileMove_Multiple_FromWatchedToUnwatched(Int32 filesCount, Boolean skipOldEvents)
        /_/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs(41,0): at System.IO.Tests.File_Move_Tests.File_Move_Multiple_From_Watched_To_Unwatched_Mac(Int32 filesCount)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/MethodInvoker.Mono.cs(33,0): at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
danmoseley commented 2 years ago

This needs disabling for macOS 12.

TestResults
| join kind=inner WorkItems on WorkItemId
| join kind=inner Jobs on JobId
| where Finished >= now(-30d) | where QueueName startswith "osx"
//| where Result == "Fail"
| where Type startswith "System.IO.Tests" and Method contains "Move_"
| project 
  Pipeline = tostring(parse_json(Properties).DefinitionName),
  Pipeline_Configuration = tostring(parse_json(Properties).configuration),
  OS = QueueName,
  Arch = tostring(parse_json(Properties).architecture),
  Test = Type1,
  Result,
  Finished,
 // Duration,
  Method
 // Build = tostring(parse_json(Properties).BuildNumber)
  //Message
  | summarize count() by OS, Result, Method
OS Result Method count_
osx.1200.amd64.open Fail Directory_Move_Multiple_From_Watched_To_Unwatched_Mac 9
osx.1200.amd64.open Fail File_Move_Multiple_From_Watched_To_Unwatched_Mac 16
osx.1015.amd64.open Pass Directory_Move_In_Nested_Directory 24
osx.1015.amd64.open Pass Directory_Move_From_Watched_To_Unwatched 12
osx.1015.amd64.open Pass Directory_Move_With_Set_NotifyFilter 12
osx.1015.amd64.open Pass Directory_Move_From_Unwatched_To_Watched 12
osx.1015.amd64.open Pass Unix_Directory_Move_To_Different_Watched_Directory 12
osx.1015.amd64.open Pass Unix_File_Move_With_Set_NotifyFilter 12
osx.1015.amd64.open Pass File_Move_From_Unwatched_To_Watched 12
osx.1015.amd64.open Pass Unix_File_Move_In_Nested_Directory 24
osx.1015.amd64.open Pass File_Move_From_Watched_To_Unwatched 12
osx.1015.amd64.open Pass Unix_File_Move_To_Same_Directory 12
osx.1015.amd64.open Pass OSX_File_Move_To_Different_Watched_Directory 12
osx.1100.amd64.open Pass Directory_Move_In_Nested_Directory 12
osx.1100.amd64.open Pass Directory_Move_From_Watched_To_Unwatched 6
osx.1100.amd64.open Pass Directory_Move_With_Set_NotifyFilter 6
osx.1100.amd64.open Pass Directory_Move_From_Unwatched_To_Watched 6
osx.1100.amd64.open Pass Unix_Directory_Move_To_Different_Watched_Directory 6
osx.1100.amd64.open Pass Unix_File_Move_With_Set_NotifyFilter 6
osx.1100.amd64.open Pass File_Move_From_Unwatched_To_Watched 6
osx.1100.amd64.open Pass Unix_File_Move_In_Nested_Directory 12
osx.1100.amd64.open Pass File_Move_From_Watched_To_Unwatched 6
osx.1100.amd64.open Pass Unix_File_Move_To_Same_Directory 6
osx.1100.amd64.open Pass OSX_File_Move_To_Different_Watched_Directory 6
osx.1015.amd64 Pass Directory_Move_In_Nested_Directory 2
osx.1015.amd64 Pass Directory_Move_From_Watched_To_Unwatched 1
osx.1015.amd64 Pass Directory_Move_With_Set_NotifyFilter 1
osx.1015.amd64 Pass Directory_Move_From_Unwatched_To_Watched 1
osx.1015.amd64 Pass Unix_Directory_Move_To_Different_Watched_Directory 1
osx.1015.amd64 Pass Unix_File_Move_With_Set_NotifyFilter 1
osx.1015.amd64 Pass File_Move_From_Unwatched_To_Watched 1
osx.1015.amd64 Pass Unix_File_Move_In_Nested_Directory 2
osx.1015.amd64 Pass File_Move_From_Watched_To_Unwatched 1
osx.1015.amd64 Pass Unix_File_Move_To_Same_Directory 1
osx.1015.amd64 Pass OSX_File_Move_To_Different_Watched_Directory 1
osx.1100.amd64 Pass Directory_Move_In_Nested_Directory 2
osx.1100.amd64 Pass Directory_Move_From_Watched_To_Unwatched 1
osx.1100.amd64 Pass Directory_Move_With_Set_NotifyFilter 1
osx.1100.amd64 Pass Directory_Move_From_Unwatched_To_Watched 1
osx.1100.amd64 Pass Unix_Directory_Move_To_Different_Watched_Directory 1
osx.1100.amd64 Pass Unix_File_Move_With_Set_NotifyFilter 1
osx.1100.amd64 Pass File_Move_From_Unwatched_To_Watched 1
osx.1100.amd64 Pass Unix_File_Move_In_Nested_Directory 2
osx.1100.amd64 Pass File_Move_From_Watched_To_Unwatched 1
osx.1100.amd64 Pass Unix_File_Move_To_Same_Directory 1
osx.1100.amd64 Pass OSX_File_Move_To_Different_Watched_Directory 1
osx.1015.amd64.open Pass Directory_Move_Multiple_From_Unatched_To_Watched 18
osx.1015.amd64.open Pass Directory_Move_Multiple_From_Watched_To_Unwatched_Mac 18
osx.1015.amd64.open Pass File_Move_Multiple_From_Unwatched_To_WatchedMac 18
osx.1015.amd64.open Pass File_Move_Multiple_From_Watched_To_Unwatched_Mac 18
jeffhandley commented 2 years ago

@Jozkee Can you take a look at this please? We need to make sure we don't have a lurking regression here.

jozkee commented 2 years ago

The reported methods lack retry logic, that's probably the only thing needed to re-enable them and keep CI green. I also tried locally on macOS 12 and was unable to repro.

adamsitnik commented 3 months ago

I can't see any recent failures, the test has not been disabled and the last comment is from 2022. I am going to close the issue.

jozkee commented 3 months ago

@adamsitnik tests were disabled in https://github.com/dotnet/runtime/pull/70365. They are still disabled in main.

adamsitnik commented 3 months ago

@Jozkee thanks! (I was searching for some more usual ways of disabling tests ;p )