search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.91k stars 4.63k forks source link

[wasm] `STJ.Serialization.Tests.JsonIgnoreAttribute_UnsupportedCollection` failing on `main` #71981

Open radical opened 2 years ago

radical commented 2 years ago

Build, and log:

    System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreAttribute_UnsupportedCollection [FAIL]
      System.UriFormatException : Invalid URI: The hostname could not be parsed.
      Stack Trace:
        /_/src/libraries/System.Private.Uri/src/System/UriExt.cs(42,0): at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind, UriCreationOptions& creationOptions)
        /_/src/libraries/System.Private.Uri/src/System/Uri.cs(369,0): at System.Uri..ctor(String uriString)
        /_/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs(1193,0): at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.JsonIgnoreAttribute_UnsupportedCollection()
        --- End of stack trace from previous location ---
  Finished:    System.Text.Json.Tests
ghost commented 2 years ago

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis See info in area-owners.md if you want to be subscribed.

Issue Details
[Build](https://dev.azure.com/dnceng/public/_build/results?buildId=1872987&view=logs&jobId=e36cdb78-1b23-5f53-5d15-e931194c7d32&j=b4344b0d-0f92-5d69-ccaf-e0b24fbf14a2&t=65a58faa-a542-5344-b5c8-897139f242cd), and [log](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-71875-merge-624f8760879e44f287/System.Text.Json.Tests/1/console.f2a38d09.log?helixlogtype=result): ``` System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreAttribute_UnsupportedCollection [FAIL] System.UriFormatException : Invalid URI: The hostname could not be parsed. Stack Trace: /_/src/libraries/System.Private.Uri/src/System/UriExt.cs(42,0): at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind, UriCreationOptions& creationOptions) /_/src/libraries/System.Private.Uri/src/System/Uri.cs(369,0): at System.Uri..ctor(String uriString) /_/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs(1193,0): at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.JsonIgnoreAttribute_UnsupportedCollection() --- End of stack trace from previous location --- Finished: System.Text.Json.Tests ```
Author: radical
Assignees: -
Labels: `area-System.Text.Json`
Milestone: -
krwq commented 2 years ago

FYI disabled tests are no longer blocking CI so removing label

radical commented 2 years ago

FYI disabled tests are no longer blocking CI so removing label

Oops, sorry, missed this one!

eiriktsarpalis commented 2 years ago

@radical PTAL at this comment: https://github.com/dotnet/runtime/pull/71875/files#r919266335

Judging by the original code in this change, this appears to be a regression in System.Uri contructor validation.

radical commented 2 years ago

@eiriktsarpalis Do you want me to revert this, or would you want to do it as part of the fixing the validation?

eiriktsarpalis commented 2 years ago

I think simply reverting the accidental change would be good for now.

ghost commented 2 years ago

Tagging subscribers to 'arch-wasm': @lewing See info in area-owners.md if you want to be subscribed.

Issue Details
[Build](https://dev.azure.com/dnceng/public/_build/results?buildId=1872987&view=logs&jobId=e36cdb78-1b23-5f53-5d15-e931194c7d32&j=b4344b0d-0f92-5d69-ccaf-e0b24fbf14a2&t=65a58faa-a542-5344-b5c8-897139f242cd), and [log](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-71875-merge-624f8760879e44f287/System.Text.Json.Tests/1/console.f2a38d09.log?helixlogtype=result): ``` System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreAttribute_UnsupportedCollection [FAIL] System.UriFormatException : Invalid URI: The hostname could not be parsed. Stack Trace: /_/src/libraries/System.Private.Uri/src/System/UriExt.cs(42,0): at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind, UriCreationOptions& creationOptions) /_/src/libraries/System.Private.Uri/src/System/Uri.cs(369,0): at System.Uri..ctor(String uriString) /_/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs(1193,0): at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.JsonIgnoreAttribute_UnsupportedCollection() --- End of stack trace from previous location --- Finished: System.Text.Json.Tests ```
Author: radical
Assignees: -
Labels: `arch-wasm`, `area-System.Text.Json`, `test-failure`
Milestone: 7.0.0