dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.27k stars 4.73k forks source link

[iOS] ZipArchive and ZipFile unicode test failures #72951

Open steveisok opened 2 years ago

steveisok commented 2 years ago

Both ExtractToDirectoryUnicode and ExtractToDirectoryExtension_Unicode fail comparing the file names extracted from unicode.zip.

What's weird is that the expected and actual file names appear to be equal:

Expected: 한글.txt

Actual: 한글.txt

If you take the strings from actual and expected and put them in a small test, they will be equal. It seems like the values returned from the file system in https://github.com/dotnet/runtime/blob/c21ae04d923a1e5d2964fed61cc919571cce2efe/src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs#L291-L292 are suspect.

Skipping the tests for now.

ghost commented 2 years ago

Tagging subscribers to this area: @dotnet/area-system-io-compression See info in area-owners.md if you want to be subscribed.

Issue Details
Both [ExtractToDirectoryUnicode](https://github.com/dotnet/runtime/blob/c21ae04d923a1e5d2964fed61cc919571cce2efe/src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Extract.cs#L37-L46) and [ExtractToDirectoryExtension_Unicode](https://github.com/dotnet/runtime/blob/c21ae04d923a1e5d2964fed61cc919571cce2efe/src/libraries/System.IO.Compression.ZipFile/tests/ZipFileExtensions.ZipArchive.Extract.cs#L25-L33) fail comparing the file names extracted from `unicode.zip`. What's weird is that the expected and actual file names appear to be equal: ``` Expected: 한글.txt Actual: 한글.txt ``` If you take the strings from actual and expected and put them in a small test, they will be equal. It seems like the values returned from the file system in https://github.com/dotnet/runtime/blob/c21ae04d923a1e5d2964fed61cc919571cce2efe/src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs#L291-L292 are suspect. Skipping the tests for now.
Author: steveisok
Assignees: -
Labels: `area-System.IO.Compression`
Milestone: -