search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.47k stars 4.76k forks source link

[iOS] BigInteger CompareTo crash in CborDocument_Roundtrip test #73150

Open steveisok opened 2 years ago

steveisok commented 2 years ago

During the System.Formats.Cbor test run, CborDocument_Roundtrip crashes when comparing two BigInteger types.

[22:22:52.0766040] =================================================================
[22:22:52.0766090]  Managed Stacktrace:
[22:22:52.0766150] =================================================================
[22:22:52.0766210]    at System.Numerics.BigInteger:CompareTo <0x00050>
[22:22:52.0766260]    at System.Numerics.BigInteger:CompareTo <0x00073>
[22:22:52.0766320]    at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00217>
[22:22:52.0766420]    at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00047>
[22:22:52.0766480]    at Xunit.Sdk.AssertEqualityComparerAdapter`1:Equals <0x000af>
[22:22:52.0766540]    at Xunit.Sdk.AssertEqualityComparer`1:CheckIfEnumerablesAreEqual <0x00207>
[22:22:52.0766640]    at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00323>
[22:22:52.0766690]    at Xunit.Assert:Equal <0x0012f>
[22:22:52.0766750]    at Xunit.Assert:Equal <0x00077>
[22:22:52.0766810]    at System.Formats.Cbor.Tests.CborPropertyTests:CborDocument_Roundtrip <0x00063>

The test will be skipped for now.

dotnet-issue-labeler[bot] commented 2 years ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ghost commented 2 years ago

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger See info in area-owners.md if you want to be subscribed.

Issue Details
During the `System.Formats.Cbor` test run, [CborDocument_Roundtrip](https://github.com/dotnet/runtime/blob/57bfe474518ab5b7cfe6bf7424a79ce3af9d6657/src/libraries/System.Formats.Cbor/tests/PropertyTests/CborPropertyTests.cs#L187) crashes when comparing two `BigInteger` types. ``` [22:22:52.0766040] ================================================================= [22:22:52.0766090] Managed Stacktrace: [22:22:52.0766150] ================================================================= [22:22:52.0766210] at System.Numerics.BigInteger:CompareTo <0x00050> [22:22:52.0766260] at System.Numerics.BigInteger:CompareTo <0x00073> [22:22:52.0766320] at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00217> [22:22:52.0766420] at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00047> [22:22:52.0766480] at Xunit.Sdk.AssertEqualityComparerAdapter`1:Equals <0x000af> [22:22:52.0766540] at Xunit.Sdk.AssertEqualityComparer`1:CheckIfEnumerablesAreEqual <0x00207> [22:22:52.0766640] at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00323> [22:22:52.0766690] at Xunit.Assert:Equal <0x0012f> [22:22:52.0766750] at Xunit.Assert:Equal <0x00077> [22:22:52.0766810] at System.Formats.Cbor.Tests.CborPropertyTests:CborDocument_Roundtrip <0x00063> ```
Author: steveisok
Assignees: -
Labels: `untriaged`, `os-ios`
Milestone: -
ghost commented 2 years ago

Tagging subscribers to this area: @dotnet/area-system-formats-cbor, @vcsjones See info in area-owners.md if you want to be subscribed.

Issue Details
During the `System.Formats.Cbor` test run, [CborDocument_Roundtrip](https://github.com/dotnet/runtime/blob/57bfe474518ab5b7cfe6bf7424a79ce3af9d6657/src/libraries/System.Formats.Cbor/tests/PropertyTests/CborPropertyTests.cs#L187) crashes when comparing two `BigInteger` types. ``` [22:22:52.0766040] ================================================================= [22:22:52.0766090] Managed Stacktrace: [22:22:52.0766150] ================================================================= [22:22:52.0766210] at System.Numerics.BigInteger:CompareTo <0x00050> [22:22:52.0766260] at System.Numerics.BigInteger:CompareTo <0x00073> [22:22:52.0766320] at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00217> [22:22:52.0766420] at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00047> [22:22:52.0766480] at Xunit.Sdk.AssertEqualityComparerAdapter`1:Equals <0x000af> [22:22:52.0766540] at Xunit.Sdk.AssertEqualityComparer`1:CheckIfEnumerablesAreEqual <0x00207> [22:22:52.0766640] at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00323> [22:22:52.0766690] at Xunit.Assert:Equal <0x0012f> [22:22:52.0766750] at Xunit.Assert:Equal <0x00077> [22:22:52.0766810] at System.Formats.Cbor.Tests.CborPropertyTests:CborDocument_Roundtrip <0x00063> ``` The test will be skipped for now.
Author: steveisok
Assignees: -
Labels: `os-ios`, `area-System.Formats.Cbor`
Milestone: 8.0.0
bartonjs commented 2 years ago

While this is potentially affecting a disabled test for CBOR, the real issue seems to be a crash in BigInteger, so transferring to numerics.

ghost commented 2 years ago

Tagging subscribers to this area: @dotnet/area-system-numerics See info in area-owners.md if you want to be subscribed.

Issue Details
During the `System.Formats.Cbor` test run, [CborDocument_Roundtrip](https://github.com/dotnet/runtime/blob/57bfe474518ab5b7cfe6bf7424a79ce3af9d6657/src/libraries/System.Formats.Cbor/tests/PropertyTests/CborPropertyTests.cs#L187) crashes when comparing two `BigInteger` types. ``` [22:22:52.0766040] ================================================================= [22:22:52.0766090] Managed Stacktrace: [22:22:52.0766150] ================================================================= [22:22:52.0766210] at System.Numerics.BigInteger:CompareTo <0x00050> [22:22:52.0766260] at System.Numerics.BigInteger:CompareTo <0x00073> [22:22:52.0766320] at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00217> [22:22:52.0766420] at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00047> [22:22:52.0766480] at Xunit.Sdk.AssertEqualityComparerAdapter`1:Equals <0x000af> [22:22:52.0766540] at Xunit.Sdk.AssertEqualityComparer`1:CheckIfEnumerablesAreEqual <0x00207> [22:22:52.0766640] at Xunit.Sdk.AssertEqualityComparer`1:Equals <0x00323> [22:22:52.0766690] at Xunit.Assert:Equal <0x0012f> [22:22:52.0766750] at Xunit.Assert:Equal <0x00077> [22:22:52.0766810] at System.Formats.Cbor.Tests.CborPropertyTests:CborDocument_Roundtrip <0x00063> ``` The test will be skipped for now.
Author: steveisok
Assignees: -
Labels: `area-System.Numerics`, `os-ios`
Milestone: 8.0.0
steveisok commented 1 year ago

@SamMonoRT do you think someone on your team can look into this?

SamMonoRT commented 1 year ago

@dakersnar - do we know what are the final plans for https://github.com/dotnet/runtime/issues/79004 - trying to determine if we should try to investigate this iOS specific issue for 8.0 timeline

SamMonoRT commented 1 year ago

@kotlarmilos - take a brief look as you enable the iOS lanes. Moving this to 9.0 due to lack of clarity above.

kotlarmilos commented 1 year ago

Didn't manage to reproduce the failure locally. However, the test fails on the CI. Further investigation is needed, thus moving this to Future.