search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.95k stars 4.65k forks source link

Consider enabling R2R when loading from a byte array on OSX #74203

Open VSadov opened 2 years ago

VSadov commented 2 years ago

Re: https://github.com/dotnet/runtime/pull/74118

With that fix we support loading assemblies with R2R code from byte arrays, however we are not enabling R2R on OSX as that requires further changes, which we are not comfortable with this close to shipping.

This issue is to follow up with changes to enable R2R in such scenario.

EDIT: we ended up disabling R2R on all platforms in this scenario. It may be worth checking if R2R has any benefits in this case.

ghost commented 2 years ago

Tagging subscribers to this area: @vitek-karas, @agocke, @vsadov See info in area-owners.md if you want to be subscribed.

Issue Details
Re: https://github.com/dotnet/runtime/pull/74118 With that fix we support loading assemblies with R2R code from byte arrays, however we are not enabling R2R on OSX as that requires further changes, which we are not comfortable with this close to shipping. This issue is to follow up with changes to enable R2R in such scenario.
Author: VSadov
Assignees: VSadov
Labels: `area-AssemblyLoader-coreclr`
Milestone: 8.0.0
agocke commented 1 year ago

Anything we plan to do here for 8.0? Or should I move this to 9.0?

vitek-karas commented 1 year ago

I moved it - there was basically no feedback on this either. We should still look into it, but it's not critical for 8.

VSadov commented 1 year ago

Agreed. This seems to be a niche scenario.