search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.82k stars 4.62k forks source link

[External] zlib has suppressed warnings #76095

Closed AaronRobinsonMSFT closed 2 weeks ago

AaronRobinsonMSFT commented 1 year ago

The following externally consumed projects require suppression of warnings that are unadvised. We should be fixing these issues and offering those fixes upstream.

zlib

https://github.com/dotnet/runtime/blob/89962a54d60e4d9c9837012d1729c5a72ec748cd/src/native/external/zlib-intel.cmake#L2 https://github.com/dotnet/runtime/blob/89962a54d60e4d9c9837012d1729c5a72ec748cd/src/native/external/zlib.cmake#L2 https://github.com/dotnet/runtime/blob/6c3c2347bd99582fc42a62e5b68edba2e0ab1483/src/mono/mono/mini/CMakeLists.txt#L341

ghost commented 1 year ago

Tagging subscribers to this area: @dotnet/area-meta See info in area-owners.md if you want to be subscribed.

Issue Details
The following externally consumed projects require suppression of warnings that are unadvised. We should be fixing these issues and offering those fixes upstream. ## zlib https://github.com/dotnet/runtime/blob/89962a54d60e4d9c9837012d1729c5a72ec748cd/src/native/external/zlib-intel.cmake#L2 https://github.com/dotnet/runtime/blob/89962a54d60e4d9c9837012d1729c5a72ec748cd/src/native/external/zlib.cmake#L2 https://github.com/dotnet/runtime/blob/6c3c2347bd99582fc42a62e5b68edba2e0ab1483/src/mono/mono/mini/CMakeLists.txt#L341 ## libunwind https://github.com/dotnet/runtime/blob/56095347ca1bacbc7a95e468f03f02ea808b9d9b/src/native/external/libunwind_extras/CMakeLists.txt#L143
Author: AaronRobinsonMSFT
Assignees: -
Labels: `area-Meta`
Milestone: 8.0.0
ghost commented 1 year ago

Tagging subscribers to this area: @dotnet/area-system-io-compression See info in area-owners.md if you want to be subscribed.

Issue Details
The following externally consumed projects require suppression of warnings that are unadvised. We should be fixing these issues and offering those fixes upstream. ## zlib https://github.com/dotnet/runtime/blob/89962a54d60e4d9c9837012d1729c5a72ec748cd/src/native/external/zlib-intel.cmake#L2 https://github.com/dotnet/runtime/blob/89962a54d60e4d9c9837012d1729c5a72ec748cd/src/native/external/zlib.cmake#L2 https://github.com/dotnet/runtime/blob/6c3c2347bd99582fc42a62e5b68edba2e0ab1483/src/mono/mono/mini/CMakeLists.txt#L341 ## libunwind https://github.com/dotnet/runtime/blob/56095347ca1bacbc7a95e468f03f02ea808b9d9b/src/native/external/libunwind_extras/CMakeLists.txt#L143
Author: AaronRobinsonMSFT
Assignees: -
Labels: `area-System.IO.Compression`
Milestone: 8.0.0
danmoseley commented 1 year ago

Could this be help wanted label?

GrabYourPitchforks commented 5 months ago

C4244 was addressed via https://github.com/dotnet/runtime/pull/91245 and the zlib patch will be merged upstream in 1.3.1.1.

IIRC the mono build work is still outstanding.

ericstj commented 2 weeks ago

I believe this is now resolved with the move to zlib-ng and https://github.com/dotnet/runtime/pull/105433 cc @carlossanlop