search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.59k stars 4.55k forks source link

Review usage of nullable suppressions (especially `!`) in CodeExporter.cs #78704

Open ViktorHofer opened 1 year ago

ViktorHofer commented 1 year ago

https://github.com/dotnet/runtime/pull/78703 adds a couple of nullable suppressions that should be removed and cleaned-up. Those suppressions are necessary as previously, the assembly compiled against ref/System.CodeDom but with the above PR now binds against src/System.CodeDom which has a different nullability setting.

ghost commented 1 year ago

Tagging subscribers to this area: @dotnet/area-meta See info in area-owners.md if you want to be subscribed.

Issue Details
https://github.com/dotnet/runtime/pull/78703 adds a couple of nullable suppressions that should be removed and cleaned-up. Those suppressions are necessary as previously, the assembly compiled against ref/System.CodeDom but with the above PR now binds against src/System.CodeDom which has a different nullability setting.
Author: ViktorHofer
Assignees: -
Labels: `area-Meta`
Milestone: 8.0.0
halgab commented 11 months ago

Winforms repo has problems as well with the current state of nullability annotations in System.CodeDom. We bumped into the same problems with CodeFieldReferenceExpression, CodePrimitiveExpression and CodePropertyReferenceExpression. See dotnet/winforms#9663