Open ManickaP opened 1 year ago
Tagging subscribers to this area: @dotnet/ncl See info in area-owners.md if you want to be subscribed.
Author: | ManickaP |
---|---|
Assignees: | - |
Labels: | `untriaged`, `area-System.Net.Quic` |
Milestone: | - |
Once #82159 is merged, this should become disabled-test issue.
This is another occurrence of #55979, i.e. msquic is silently dropping connections due to the machine being too slow.
I've temporarily added statistics (https://github.com/dotnet/runtime/commit/6709e8e53c0924f37503e9e5940e2f6a7f3f25c0) and they show multiple dropped connections.
I'm moving this to future as we don't have any solution for this problem. Maybe we could even close this against #55979
That is pretty sad that we cannot make single test reliable. I'm wondering if we can use the counter to adjust the expectation or decrease the concurrency for ARM. (or tune the drop threshold)
cc: @nibanks
That is pretty sad that we cannot make single test reliable.
You can't run a single test without failing? From my previous understanding, QUIC was getting overwhelmed by too much getting queued, and it was (by design) aborting the connection because it could no longer provide the time guarantees to have a reliable connection. But this wasn't caused by just 1 test.
In this particular test, there is single listener and many parallel attempts to negotiate connection - this test was added recently to verify handling accept queue inside .NET.
Failed for me on x64 as well while running tests on my VM over the weekend
System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
Condition(s) not met: "IsQuicUnsupported"
Assert.Equal() Failure
Expected: 100
Actual: 94
Stack Trace:
/home/furt/github/wfurt-runtime/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs(251,0): at System.Net.Quic.Tests.QuicListenerTests.Listener_BacklogLimitRefusesConnection_ParallelClients_ClientThrows_Core(Int32 backlogLimit, Int32 connectCount)
/home/furt/github/wfurt-runtime/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs(268,0): at System.Net.Quic.Tests.QuicListenerTests.Listener_BacklogLimitRefusesConnection_ParallelClients_ClientThrows_Core(Int32 backlogLimit, Int32 connectCount)
For some reason I have mismatched the issues, the comments belong to #82769 :facepalm:
I'm wondering if the milestone is right @ManickaP. Are we going to support armv6 or s390x architectures? While https://github.com/dotnet/runtime/issues/82769 happened on supported HW I think this is one is not.
SupportedLinuxPlatforms_IsSupportedIsTrue
It is also failing on helix for linux-armv6:
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-21c096763250462988/System.Net.Quic.Functional.Tests/3/console.f2cd77de.log?helixlogtype=result
and linux-s390x:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-053a9df11f6d452495/System.Net.Quic.Functional.Tests/3/console.2de1fd1f.log?helixlogtype=result
_Originally posted by @am11 in https://github.com/dotnet/runtime/pull/82108#discussion_r1106439604_
EDIT: I did a search in DevOps tests:
And seems like these 2 platforms:
Are the only remaining failing ones, as of now.
Known Issue Error Message
Fill the error message using known issues guidance.
Report
Summary