dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.12k stars 4.7k forks source link

[Loc]With .NET 7 preview7 installed on locale OS, some strings are unlocalized during installing workload and publish in CLI. #85067

Open vdanche opened 2 years ago

vdanche commented 2 years ago

.NET 7 preview7 installed on locale OS(e.g DE)

Repro: Step1:Install wasm-tools

dotnet workload install wasm-tools --skip-manifest-update

        Step3: New blazorWasm 

                        dotnet new blazorwasm 

Step2: dotnet publish with AOT enable Adding “true” to csproj file to use AOT compilation, like this

<PropertyGroup> <TargetFramework>net7.0</TargetFramework> <RunAOTCompilation>true</RunAOTCompilation></PropertyGroup>

Check if strings are localized well. Expected Result: Strings are localized well

Actual Result: Step1: Some strings are not localized well during installing workload

image

Step2; Some strings are not localized well during publishing E.g(DE) image

marcpopMSFT commented 2 years ago

I don't believe most localization for .net 7 has been done yet. At least for the SDK, we are enabling that for RC1.

vdanche commented 2 years ago

Still repro on NET7 RC2 SDK(7.0.100-rc.2.22471.15) e.g TK image

marcpopMSFT commented 2 years ago

All the strings are fixed in rc1 except for download/done. We'll have to fix those in 7.0.2xx: https://github.com/dotnet/sdk/blob/release/7.0.1xx-rc1/src/Cli/dotnet/commands/dotnet-workload/install/NetSdkMsiInstallerClient.cs#L774

@joeloff good workloads introduction bug for @nagilson?

vdanche commented 2 years ago

All the strings are fixed in rc1 except for download/done. We'll have to fix those in 7.0.2xx: https://github.com/dotnet/sdk/blob/release/7.0.1xx-rc1/src/Cli/dotnet/commands/dotnet-workload/install/NetSdkMsiInstallerClient.cs#L774

@joeloff good workloads introduction bug for @nagilson?

@marcpopMSFT some strings during publish still unlocalized in NET7 RC2. image

marcpopMSFT commented 2 years ago

@agocke the first three strings listed in the above screenshots come from runtime: https://github.com/dotnet/runtime/blob/main/src/mono/wasm/build/WasmApp.Native.targets#L323

That last one comes from the Blazor SDK @javiercn https://github.com/dotnet/sdk/blob/main/src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets#L581

vdanche commented 1 year ago

another strings "stripping symbols from..." also should be localized during publish e.g DE image

marcpopMSFT commented 1 year ago

I believe that last one is also part of the list from the runtime that @agocke would own.

nagilson commented 1 year ago

Unassigning as it's up to those teams to translate their messages

marcpopMSFT commented 1 year ago

Moving to runtime as the remaining strings come from here we believe.

v-ainigao commented 1 year ago

Also repro on net8.0.100-rc.2.23466.1(runtime- 8.0.0-rc.2.23464.16). e.g JP: 2 1

lewing commented 6 months ago

It looks like we are missing localizations for several of the messages in the workloads.

cc @maraf @akoeplinger