Closed BruceForstall closed 1 year ago
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.
Author: | BruceForstall |
---|---|
Assignees: | - |
Labels: | `arch-arm64`, `os-windows`, `JitStress`, `area-CodeGen-coreclr`, `blocking-clean-ci-optional` |
Milestone: | 8.0.0 |
@kunalspathak
This seems to be related to https://github.com/dotnet/runtime/issues/87515 because I bisect the issue to https://github.com/dotnet/runtime/pull/85551
@tannergooding
That would likely put it in the realm of https://github.com/dotnet/runtime/issues/87502, which is that there are some bits of code throughout the JIT that are making assumptions about the state/handling of SIMD and aren't doing it consistently.
This leads to downstream issues when the support is disabled, which can negatively impact R2R or other scenarios.
This leads to downstream issues when the support is disabled, which can negatively impact R2R or other scenarios.
What is the action item here? How do we want to tackle it?
We need to identify the places that are making assumptions and ensure they are updated to "do the right thing".
There's effectively two types of code we can encounter:
Code that exists just as an optimization should respect the DOTNET_EnableHWIntrinsic=0
flag (and related baseline flags) and not light up if its off.
Code that exists for ABI purposes likely needs to ignore the DOTNET_EnableHWIntrinsic=0
flag (and related baseline flags) and emit the correct codegen/handling regardless. This is because its part of the baseline support and so is required to work in order for HFA/HVA handling, among many other factors.
Thanks @tannergooding. I am assigning this to you for now.
win/arm64
Pipeline: runtime-coreclr jitstress-isas-arm coreclr windows arm64 Checked jitstress_isas_nohwintrinsic @ Windows.11.Arm64.Open JIT.SIMD Work Item
https://dev.azure.com/dnceng-public/public/_build/results?buildId=302647&view=ms.vss-test-web.build-test-results-tab&runId=6137478&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab&resultId=110096
Related? https://github.com/dotnet/runtime/issues/87511 https://github.com/dotnet/runtime/issues/87388