search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15k stars 4.67k forks source link

[perf] System.Globalization.** performance regressions in Mono AOT x64 microbenchmarks from Preview 5 to Preview 7 #89250

Closed kotlarmilos closed 1 month ago

kotlarmilos commented 1 year ago

Description

The following performance regressions occurred between the Preview 4 snapshot (May 2nd, 2023) and Preview 7 snapshot (July 19th, 2023).

The configuration used for the benchmarks is Mono AOT with LLVM on x64 ubuntu 18.04.

Name Baseline Value Compare Value % Difference
System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (en-US, Ordinal, False)) 232.74 522.51 124.5
kotlarmilos commented 1 year ago

@mkhamoyan @ilonatommy We are trying to narrow down changes between May 2nd, 2023 and July 19th, 2023 that may have caused the regressions. If you are aware of any changes that might have potentially caused these regressions, please let us know.

mkhamoyan commented 1 year ago

This can be related to HybridGlobalization changes but what is surprising for me that platform is x64 ubuntu. HybridGlobalization mode is supported on iOS/tvOS/MacCatalyst/Browser platforms. Can you give more details related to calculations?

kotlarmilos commented 1 year ago

Sorry for the late reply. Your changes shouldn't affected the microbenchmark since the HybridGlobalization is not enabled yet. It looks like span-related regression https://github.com/dotnet/runtime/issues/89247#issuecomment-1644142104.

steveisok commented 1 month ago

Since this is about .net 8 previews, there's not much action we can take. Closing