search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.03k stars 4.67k forks source link

[FileCheck] Only run disasm-checks on checked builds #89396

Open TIHan opened 1 year ago

TIHan commented 1 year ago

@jakobbotsch mentioned in here:

Release jitdisasm and checked jitdisasm are subtly different in a few ways, so it seems like a bad idea... can we instead change file check to only run with checked JITs?

We should consider only running these tests in checked builds as to reduce any variance that may occur between checked and release builds.

ghost commented 1 year ago

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.

Issue Details
@jakobbotsch mentioned in [here](https://github.com/dotnet/runtime/issues/89357): > Release jitdisasm and checked jitdisasm are subtly different in a few ways, so it seems like a bad idea... can we instead change file check to only run with checked JITs? We should consider only running these tests in checked builds as to reduce any variance that may occur between checked and release builds.
Author: TIHan
Assignees: -
Labels: `area-CodeGen-coreclr`
Milestone: -
JulieLeeMSFT commented 1 month ago

We don't have time to work on this in .NET 9. Pushing out to .NET 10.