search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.43k stars 4.76k forks source link

Annotate remaining libraries for Nullable Reference Types #90400

Open stephentoub opened 1 year ago

stephentoub commented 1 year ago

The following libraries in dotnet/runtime have not been annotated for Nullable Reference Types.

For each, we should either do so or decide we're never doing so.

ghost commented 1 year ago

Tagging subscribers to this area: @dotnet/area-meta See info in area-owners.md if you want to be subscribed.

Issue Details
The following libraries in dotnet/runtime have not been annotated for Nullable Reference Types. - [ ] Microsoft.Extensions.Hosting.Systemd - [ ] System.CodeDom - [ ] System.Diagnostics.EventLog - [ ] System.Diagnostics.PerformanceCounter - [ ] System.DirectoryServices.AccountManagement - [ ] System.DirectoryServices.Protocols - [ ] System.IO.Ports - [ ] System.Management - [ ] System.Runtime.Caching - [ ] System.Speech For each, we should either do so or decide we're never doing so.
Author: stephentoub
Assignees: -
Labels: `area-Meta`
Milestone: Future
maranmaran commented 1 year ago

Are there any specific decisions so far about "never doing so" or listed libs are up for grabs and PR per lib?

halgab commented 1 year ago

I'm currently working on annotations for System.CodeDom. Should I send one big PR for the whole assembly or should I slice it in smaller parts?

stephentoub commented 8 months ago

Are there any specific decisions so far about "never doing so" or listed libs are up for grabs and PR per lib?

Nope

I'm currently working on annotations for System.CodeDom. Should I send one big PR for the whole assembly or should I slice it in smaller parts?

Either way is fine.