Closed performanceautofiler[bot] closed 5 months ago
Only win-x64-Intel machine regressed, suspects are https://github.com/dotnet/runtime/pull/90325 cc @tannergooding and https://github.com/dotnet/runtime/pull/90318 cc @jakobbotsch
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.
Author: | performanceautofiler[bot] |
---|---|
Assignees: | - |
Labels: | `os-windows`, `tenet-performance`, `tenet-performance-benchmarks`, `arch-x64`, `area-CodeGen-coreclr`, `untriaged`, `runtime-coreclr` |
Milestone: | - |
There's a bunch of RA diffs but I don't really see why they would cause perf diffs, maybe JCC erratum? There's a few new instances of those (but some old instances also disappear) when I check with DOTNET_JitDisasmWithAlignmentBoundaries=1
.
FWIW, the diffs seem to be triggered by #90496 kicking in @EgorBo:
Seems like we shouldn't be creating new locals for this case if the previous logic didn't need to (but it's not the cause of the diffs, I guess the cause is the early folding away of the BB?)
System.Collections.Sort<IntStruct>.Array(Size: 512)
Hot functions:
System.Collections.Generic.GenericArraySortHelper`1.PickPivotAndPartition
(Tier-1)
System.Collections.Generic.GenericArraySortHelper`1.IntroSort
(Tier-1)
System.Collections.Sort<IntStruct>.List(Size: 512)
Hot functions:
System.Collections.Generic.GenericArraySortHelper`1.PickPivotAndPartition
(Tier-1)
System.Collections.Generic.GenericArraySortHelper`1.IntroSort
(Tier-1)
@jakobbotsch thanks for the investigation!! Indeed seems like my PR introduced a bit more conservative side-effect extraction than previously, I'll check whether I can relax that or handle downstream but looks like only one machine regressed according to ADX query:
so I am going to move this to 9.0 as non-important.
I didn't blame my PR initially because I thought it's Tier0 only but you correctly pointed out it's not
Looks like the regression was either fixed or compensated by https://github.com/dotnet/runtime/pull/98324
Run Information
Regressions in System.Collections.Sort<IntStruct>
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md