dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.47k stars 4.76k forks source link

Clean up dependencies on 8.0 packages. #92502

Closed ericstj closed 11 months ago

ericstj commented 1 year ago

Having a look through https://github.com/dotnet/runtime/blob/main/eng/Versions.props we still depend on a few 8.0 packages.

Summarizing the ones I see and tagging the folks who might need to take action. Feel free to update this as needed.

ghost commented 1 year ago

Tagging subscribers to this area: @dotnet/runtime-infrastructure See info in area-owners.md if you want to be subscribed.

Issue Details
Having a look through https://github.com/dotnet/runtime/blob/main/eng/Versions.props we still depend on a few 8.0 packages. Summarizing the ones I see and tagging the folks who might need to take action. Feel free to update this as needed. - [ ] Arcade @mmitche do we have a new build of arcade for 9.0 that we can start picking up? https://github.com/dotnet/runtime/blob/e51acb55cd57eecaefac5f3008ca91c6364b4223/eng/Versions.props#L84-L100 - [ ] ILAsm looks like a bad merge here has frozen our version for some time. Fixing in https://github.com/dotnet/runtime/pull/92500 https://github.com/dotnet/runtime/blob/e51acb55cd57eecaefac5f3008ca91c6364b4223/eng/Versions.props#L107-L108 - [ ] Runtime-assets - @carlossanlop can you help update our subscription and make sure we have a 9.0 build of runtime-assets. https://github.com/dotnet/runtime/blob/e51acb55cd57eecaefac5f3008ca91c6364b4223/eng/Versions.props#L141-L155 - [ ] XHarness Looks like this is still branded as 8.0 - https://github.com/dotnet/runtime/blob/e51acb55cd57eecaefac5f3008ca91c6364b4223/eng/Versions.props#L182-L185 - [ ] Intellisense @carlossanlop we should retarget this to 9.0 when we're ready - https://github.com/dotnet/runtime/blob/e51acb55cd57eecaefac5f3008ca91c6364b4223/eng/Versions.props#L208 - [ ] MSQuic @karelz can you help find someone to help here https://github.com/dotnet/runtime/blob/e51acb55cd57eecaefac5f3008ca91c6364b4223/eng/Versions.props#L219 - [ ] 8.0 version @ViktorHofer can you help with this, once we have a final build of 8.0? https://github.com/dotnet/runtime/blob/e51acb55cd57eecaefac5f3008ca91c6364b4223/eng/Versions.props#L10C6-L10C24
Author: ericstj
Assignees: -
Labels: `area-Infrastructure`
Milestone: -
ViktorHofer commented 1 year ago

8.0 version @ViktorHofer can you help with this, once we have a final build of 8.0? https://github.com/dotnet/runtime/blob/e51acb55cd57eecaefac5f3008ca91c6364b4223/eng/Versions.props#L10C6-L10C24

@steveisok usually takes care of updating these

akoeplinger commented 12 months ago

Only the Intellisense package is left here, @carlossanlop for my own understanding: where is this package produced?

carlossanlop commented 12 months ago

Only the Intellisense package is left here, @carlossanlop for my own understanding: where is this package produced?

It gets produced on demand (manually) through this pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=386331&view=results

Specifically, this build step pushes the package to the feed: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=386331&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706

In .NET 7, we pushed it to the dotnet7-transport: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet7-transport/NuGet/Microsoft.Private.Intellisense/

And in .NET 8, to the dotnet8-transport: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet8-transport/NuGet/Microsoft.Private.Intellisense/

We have not generated any for .NET 9.

ViktorHofer commented 12 months ago

Exactly. We usually keep using the previous major versioned package until we produce a new one. I think that's fine.

akoeplinger commented 11 months ago

Could we generate one for .NET 9 so we could remove our dotnet8/dotnet8-transport feed dependencies?

Checking the pipeline logs it also looks like the 8.0.0-preview-20230918.1.nupkg package was pushed to the dotnet7-transport feed so not sure how it made it to dotnet8-transport?

ViktorHofer commented 11 months ago

Could we generate one for .NET 9 so we could remove our dotnet8/dotnet8-transport feed dependencies?

We manually push that package to the corresponding feed. In this case, we can just download the latest available package and push it into the dotnet9-transport feed.

akoeplinger commented 11 months ago

Ok can you do that? I don't have permission.

ViktorHofer commented 11 months ago

We need to ask someone from core-eng to do that for us. We don't have permissions anymore.

ViktorHofer commented 11 months ago

I think this issue should now be closed. dotnet8 feeds were removed with https://github.com/dotnet/runtime/pull/95860. We don't plan to update to a new Intellisense package until later in the release.

akoeplinger commented 11 months ago

Yep, I filed https://github.com/dotnet/runtime/issues/96084 to track the intellisense package upgrade