search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.69k stars 4.59k forks source link

[mono][perf] iOS disk size regression on 3 Oct 2023 #93072

Closed LeVladIonescu closed 5 days ago

LeVladIonescu commented 10 months ago

Description

Disk size (SOD) regressions detected in HelloiOS app for both llvm and nollvm configurations.

Details

Date Diff Change Size increase (bytes) Size increase (%)
3 Oct 2023 https://github.com/dotnet/runtime/compare/88f25474334bfb0da10e0b5acb0219a64a04828b...d2e24fa59d5259000b803cb4efc0dfd2c7ea0b37 https://github.com/dotnet/runtime/pull/90764 1066800 5,01

273588138-a8439c5e-2f14-4ddc-b9a3-f32cf8d7427a

Steps to get the app sizes

  1. git checkout b9e01455c2247454ec0301b8465f7168eebd6a09 (checkout to our commit's parent)
  2. cd src/mono/sample/iOS
  3. sudo make runtimepack TARGET=iossimulator MONO_ARCH=arm64 MONO_CONFIG=Release (build the runtime)
  4. sudo make run-sim MONO_CONFIG=Release MONO_ARCH=arm64 (build the app bundle)
  5. ls -la bin/iossimulator-arm64/Bundle/HelloiOS/Release-iphonesimulator/HelloiOS.app (the app to look for is HelloiOS)
ghost commented 10 months ago

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos See info in area-owners.md if you want to be subscribed.

Issue Details
### Description Disk size (SOD) regressions detected in HelloiOS app for both llvm and nollvm configurations. #### Details - TBD Date | Diff | Change | Size increase (bytes) | Size increase (%) --|--|--|--|-- 3 Oct 2023 | | | |
Author: LeVladIonescu
Assignees: matouskozak
Labels: `untriaged`, `area-Codegen-JIT-mono`, `area-Codegen-AOT-mono`, `os-ios`
Milestone: -
ghost commented 10 months ago

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar See info in area-owners.md if you want to be subscribed.

Issue Details
### Description Disk size (SOD) regressions detected in HelloiOS app for both llvm and nollvm configurations. #### Details - TBD Date | Diff | Change | Size increase (bytes) | Size increase (%) --|--|--|--|-- 3 Oct 2023 | | | |
Author: LeVladIonescu
Assignees: matouskozak
Labels: `area-Codegen-AOT-mono`, `os-ios`, `size-reduction`
Milestone: -
SamMonoRT commented 10 months ago

Regression as seen in https://msit.powerbi.com/groups/me/apps/54e0e83f-07bc-45bf-87b7-a7677ff3af2a/reports/161e76f5-dad3-4b78-b4d2-56db2da6bdc4/ReportSectionc6d3e2c09b9adee234d0?experience=power-bi

image

MichalPetryka commented 10 months ago

Could this be #90764?

matouskozak commented 10 months ago

Could this be #90764?

@MichalPetryka we think so, but we don't have confirmation yet. @LeVladIonescu any update on reproducing the regression with said commit?

LeVladIonescu commented 9 months ago

I've got locally the results showing the size increase after https://github.com/dotnet/runtime/pull/90764.

matouskozak commented 5 days ago

Closing in favor of https://github.com/dotnet/runtime/issues/105701, feel free to re-open if you think this issue requires a separate attention.