search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.26k stars 4.73k forks source link

JIT: Audit HW intrinsic lowering code for LIR ordering #93211

Open jakobbotsch opened 1 year ago

jakobbotsch commented 1 year ago

A lot of the HW intrinsic lowering code seems to make assumptions about the definition order of operands, which is illegal in LIR. #92766 is one such case that #93210 is fixing. We should audit the rest of the HW intrinsic lowering code and fix the remaining cases that make this assumption.

ghost commented 1 year ago

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.

Issue Details
A lot of the HW intrinsic lowering code seems to make assumptions about the definition order of operands, which is illegal in LIR. #92766 is one such case that #93210 is fixing. We should audit the rest of the HW intrinsic lowering code and fix the remaining cases that make this assumption.
Author: jakobbotsch
Assignees: -
Labels: `area-CodeGen-coreclr`
Milestone: -
JulieLeeMSFT commented 7 months ago

@BruceForstall, can you check what should be done from the backend team?