[browser] Improvements for native library linking

[maraf]

• [ ] Missing blittable types
  • [x] Enum
  • It should already work https://github.com/dotnet/runtime/blob/7420ee78b7fc63bcefbbd82b0a382599302c99b4/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs#L396-L399
  • [x] Structures
  • [x] Function pointers (blocked on S.R version due to MSBuild),
  • ❓Should we allow to manually pass additiona signatures we can't parse?
  • 💡Rewrite generator to S.R.M
• [ ] Frozen emscripten cache
  • If EmccExtraLDFlags includes -sUSE_SDL=2, like -lSDL -sUSE_SDL=2, build fails
  • @radekdoulik suggested to remove frozen when WasmCachePath is set
  • https://github.com/dotnet/runtime/issues/83281#issuecomment-1651560470
  • Seems like an emsdk bug with frozen cache and additional libraries
  • https://github.com/emscripten-core/emscripten/issues/19198
• [ ] Uno's WasmShellAdditionalPInvokeLibrary
  • Matches our internal _WasmPInvokeModules
  • We compute the list from NativeFileReference
  • ❓Should we make the MSBuild item public?
• [ ] Managed2Native static local function - invalid trampoline name
• [x] Multiple pinvokes with the same entry point should generate separate entries in pinvoke-table.h with appropriate signatures
  • This appears to not actually be possible due to WASM's ABI, so marking as complete. Anyone who needs this can file an issue to discuss further.
• [ ] Delegates in pinvokes
• [ ] Strings in pinvokes
• [ ] Varargs in pinvokes
• [x] InlineArray in pinvokes
• [ ] Empty structs in pinvokes

[ghost]

Tagging subscribers to 'arch-wasm': @lewing See info in area-owners.md if you want to be subscribed.

Issue Details

---

- [ ] **Missing blittable types** - Enum - It should already work https://github.com/dotnet/runtime/blob/7420ee78b7fc63bcefbbd82b0a382599302c99b4/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs#L396-L399 - Structures - Function pointers (blocked on S.R version due to MSBuild), - ❓Should we allow to manually pass additiona signatures we can't parse? - 💡Rewrite generator to S.R.M - [ ] **Frozen emscripten cache** - If `EmccExtraLDFlags` includes `-sUSE_SDL=2`, like `-lSDL -sUSE_SDL=2`, build fails - @radekdoulik suggested to remove frozen when WasmCachePath is set - https://github.com/dotnet/runtime/issues/83281#issuecomment-1651560470 - Seems like an emsdk bug with frozen cache and additional libraries - https://github.com/emscripten-core/emscripten/issues/19198 - [ ] **Uno's `WasmShellAdditionalPInvokeLibrary`** - Matches our internal `_WasmPInvokeModules` - We compute the list from `NativeFileReference` - ❓Should we make the MSBuild item public? - [ ] **Managed2Native static local function - invalid trampoline name**

Author:	maraf
Assignees:	-
Labels:	`arch-wasm`, `area-Build-mono`, `os-browser`
Milestone:	9.0.0

[maraf]

cc @Perksey

[Perksey]

Many thanks for opening ❤️

Yep, enum blittability was fixed and didn't encounter any issues here beyond attempt 1, just wasn't in the first time we tried it.

[maraf]

@Perksey Thank you for great feedback in your article https://perksey.com/blog/blazor-silkdotnet.html

[lewing]

@kg can you update the tracking on this?

[kg]

Should be up to date now based on the work I did. It's possible other stuff works too.