dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.44k stars 4.76k forks source link

[API Proposal]: Arm64: FEAT_SVE_SHA3 #94425

Open a74nh opened 1 year ago

a74nh commented 1 year ago
namespace System.Runtime.Intrinsics.Arm

/// VectorT Summary
public abstract class SveSha3 : AdvSimd /// Feature: FEAT_SVE_SHA3
{

  /// T: long, ulong
  public static unsafe Vector<T> BitwiseRotateLeftBy1AndXor(Vector<T> left, Vector<T> right); // RAX1

  /// total method signatures: 1

}

/// Full API
public abstract class SveSha3 : AdvSimd /// Feature: FEAT_SVE_SHA3
{
    /// BitwiseRotateLeftBy1AndXor : Bitwise rotate left by 1 and exclusive OR

    /// svint64_t svrax1[_s64](svint64_t op1, svint64_t op2) : "RAX1 Zresult.D, Zop1.D, Zop2.D"
  public static unsafe Vector<long> BitwiseRotateLeftBy1AndXor(Vector<long> left, Vector<long> right);

    /// svuint64_t svrax1[_u64](svuint64_t op1, svuint64_t op2) : "RAX1 Zresult.D, Zop1.D, Zop2.D"
  public static unsafe Vector<ulong> BitwiseRotateLeftBy1AndXor(Vector<ulong> left, Vector<ulong> right);

  /// total method signatures: 2
  /// total method names:      1
}

  /// Total ACLE covered across API:      2
ghost commented 1 year ago

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics See info in area-owners.md if you want to be subscribed.

Issue Details
```csharp namespace System.Runtime.Intrinsics.Arm /// VectorT Summary public abstract class SveSha3 : AdvSimd /// Feature: FEAT_SVE_SHA3 { /// T: long, ulong public static unsafe Vector BitwiseRotateLeftBy1AndXor(Vector left, Vector right); // RAX1 /// total method signatures: 1 } /// Full API public abstract class SveSha3 : AdvSimd /// Feature: FEAT_SVE_SHA3 { /// BitwiseRotateLeftBy1AndXor : Bitwise rotate left by 1 and exclusive OR /// svint64_t svrax1[_s64](svint64_t op1, svint64_t op2) : "RAX1 Zresult.D, Zop1.D, Zop2.D" public static unsafe Vector BitwiseRotateLeftBy1AndXor(Vector left, Vector right); /// svuint64_t svrax1[_u64](svuint64_t op1, svuint64_t op2) : "RAX1 Zresult.D, Zop1.D, Zop2.D" public static unsafe Vector BitwiseRotateLeftBy1AndXor(Vector left, Vector right); /// total method signatures: 2 /// total method names: 1 } /// Total ACLE covered across API: 2 ```
Author: a74nh
Assignees: -
Labels: `area-System.Runtime.Intrinsics`
Milestone: -
a74nh commented 1 year ago

This contributes to https://github.com/dotnet/runtime/issues/93095

It covers all of the instructions in FEAT_SVE_SHA3. This list was auto generated from the C ACLE for SVE, and is in three parts:

The methods list reduced down to Vector versions. All possible varaints of T are given above the method. The complete list of all methods. The corresponding ACLE methods and SVE instructions are given above the method. All rejected ACLE methods. These are methods we have agreed that do not need including in C#. Where possible, existing C# naming conventions have been matched.

Many of the C functions include predicate argument(s), of type svbool_t as the first argument. These are missing from the C# method. It is expected that the Jit will create predicates where required, or combine with uses of conditionalSelect(). For more discussion see https://github.com/dotnet/runtime/issues/88140 comment.