search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.85k stars 4.62k forks source link

XUnitLogChecker: Enable for NativeAOT tests #94722

Open carlossanlop opened 9 months ago

carlossanlop commented 9 months ago

In PR https://github.com/dotnet/runtime/pull/93906, NativeAOT is skipped on purpose (code) because test runs are unable to find dotnet.exe to execute XUnitLogChecker.dll, so the logic will need to be adjusted for NativeAOT tests so that the tool gets built as a single file (that's one option).

ghost commented 9 months ago

Tagging subscribers to this area: @hoyosjs See info in area-owners.md if you want to be subscribed.

Issue Details
In PR https://github.com/dotnet/runtime/pull/93906, NativeAOT is skipped on purpose ([code](https://github.com/dotnet/runtime/blob/69df4b6357d0e5fe6d167bd15a40d9936d1f765f/Directory.Build.props#L337)) because test runs are unable to find dotnet.exe to execute XUnitLogChecker.dll, so the logic will need to be adjusted for NativeAOT tests so that the tool gets built as a single file (that's one option).
Author: carlossanlop
Assignees: -
Labels: `area-Infrastructure-coreclr`
Milestone: -
carlossanlop commented 9 months ago

Tagging NativeAOT owners @agocke and @dotnet/ilc-contrib - My change that adds XUnitLogChecker support for libraries tests is skipping NativeAOT tests on purpose because they run the tests differently: https://github.com/dotnet/runtime/pull/94868

I wanted to put this in your radar to ensure this gets addressed at some point.

carlossanlop commented 7 months ago

Closely related to https://github.com/dotnet/runtime/issues/94270

JulieLeeMSFT commented 2 months ago

@agocke, checking if you plan to enable crash dump on NativeAOT in .NET 9. cc @jkotas.

JulieLeeMSFT commented 2 months ago

Same question for https://github.com/dotnet/runtime/issues/94270.

agocke commented 2 months ago

I would certainly like to compile the logchecker with Native AOT. I've been trying to get to the bottom of other infra issues right now, but that would be nice to resolve.