Inspect ASM helpers for JCC Erratum

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.

https://docs.microsoft.com/dotnet/core/

MIT License

14.59k stars 4.55k forks source link

Inspect ASM helpers for JCC Erratum #99125

Open EgorBo opened 4 months ago

EgorBo commented 4 months ago

We have quite a few hand-written asm helpers, we should check those for JCC Erratum and pad with nops by hands where needed. E.g. write barriers

ghost commented 4 months ago

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.

Issue Details

We have quiter a few hand-written asm helpers, we should check those for JCC Erratum and pad with nops by hands where needed. E.g. write barriers

Author:	EgorBo
Assignees:	-
Labels:	`area-CodeGen-coreclr`
Milestone:	-

kunalspathak commented 1 month ago

The JCC erratum is "Intel only" and has no impact on other processors like AMD, so padding those on processors like AMD might increase the code size of these helpers without achieving anything observable.