search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.16k stars 4.72k forks source link

SPMI: superpmi-collect broken #99758

Closed jakobbotsch closed 7 months ago

jakobbotsch commented 7 months ago

The win-x64 NAOT collection is tiny (5.5 MB). It usually is ~330 MB.

win-x64 console log from 9843659f: https://helixri107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-140dc24f4c4042d2b5/0/1/console.5bb53a31.log?sv=2021-08-06&se=2024-06-11T11%3A23%3A32Z&sr=c&sp=rl&sig=CuoWPMt1BqsfFgZ%2Bkm1eiF7nnnIW%2B6asPpAedwNiQKk%3D

[12:28:09] Loaded 32436  Jitted 32436  FailedCompile 12 Excluded 0 Missing 12

win-x64 console log from 825f053e: https://helixri107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-bcda659adfb44a11a5/0/1/console.286b2c3c.log?sv=2021-08-06&se=2024-06-12T05%3A25%3A36Z&sr=c&sp=rl&sig=is14XKi4aFOQBEUGytXHMiTeguUFDmGsqsrvFL%2FKdA8%3D lots of misses/exceptions thrown during JIT. 

[06:20:11] Loaded 1448  Jitted 1448  FailedCompile 514 Excluded 0 Missing 508

Range: https://github.com/dotnet/runtime/compare/9843659...825f053

The SPMI changes in #99265 look suspicious, cc @EgorBo. It changed a CreateAgnostic_CORINFO_RESOLVED_TOKENin to StoreAgnostic_CORINFO_RESOLVED_TOKEN from what I can tell?

jakobbotsch commented 7 months ago

Doesn't just seem to be NAOT -- most collections are very small.