search

dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.42k stars 199 forks source link

[NativeAOT-LLVM] Implement exception dispatch info support #2341

Closed SingleAccretion closed 1 year ago

SingleAccretion commented 1 year ago

This is used by the task infrastructure to capture stack traces; without this we lose stack traces for exceptions captured in tasks.

The support is a bit best-effort because of the difference in how stack traces are captured, but it did work well for the cases I was debugging.

SingleAccretion commented 1 year ago

@dotnet/nativeaot-llvm

SingleAccretion commented 1 year ago

I guess there is no smoke test for this?

Yes. I didn't add any because this is not really a fully functional implementation (as managed stack traces are in general NYI). There are some tests in src/libraries/System.Runtime/tests which exercise EDI (and which will have to be disabled once we start running them).

jkotas commented 1 year ago

Thank you