[Async-2] A few small tweaks on the managed side of state-machine based implementation.

dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.

MIT License

1.4k stars 196 forks source link

Closed VSadov closed 9 months ago

VSadov commented 9 months ago

A few tweaks:

made AwaitableProxy a struct because we can
unlink Notifier
to not keep it rooted in TLS longer than necessary
use ExceptionDispatchInfo to rethrow to preserve stacks/watson bucketing info etc...

VSadov commented 9 months ago

I did not see any impact on benchmarks, just a few things that I noticed while getting more familiar with the state-machine based implementation.

VSadov commented 9 months ago

I assume this is ok to merge?

jakobbotsch commented 9 months ago

I assume this is ok to merge?

Yes, it looks fine to me (already approved it)