dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.38k stars 192 forks source link

[NativeAOT-LLVM] Publishing broken #2461

Closed yowl closed 8 months ago

yowl commented 8 months ago

@jkotas, Please can you tell me what the error is again? Last successful publish was

image

Thanks.

jkotas commented 8 months ago

Build tests is failing in windows-x64 Release AllConfigurations. Log: buildlog.txt

jkotas commented 8 months ago

Let me know if you need anything else.

yowl commented 8 months ago

Build tests is failing in windows-x64 Release AllConfigurations. Log: buildlog.txt

I see, yes looks like it only builds the libs subset, will see why that is.

yowl commented 8 months ago

Can you post the error from the latest build please?

jkotas commented 8 months ago

windows-x64 Release AllConfigurations - Run tests in single file mode is failing with:

2023-12-15T21:24:50.2971736Z ##[section]Starting: Run tests in single file mode
2023-12-15T21:24:50.3203885Z ==============================================================================
2023-12-15T21:24:50.3204024Z Task         : Command line
2023-12-15T21:24:50.3204095Z Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
2023-12-15T21:24:50.3204200Z Version      : 2.231.1
2023-12-15T21:24:50.3204257Z Author       : Microsoft Corporation
2023-12-15T21:24:50.3204333Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
2023-12-15T21:24:50.3204439Z ==============================================================================
2023-12-15T21:24:52.5536962Z Generating script.
2023-12-15T21:24:52.5605890Z Script contents: shell
2023-12-15T21:24:52.5611394Z D:\a\_work\1\s/src/tests/run.cmd runnativeaottests Release x64
2023-12-15T21:24:52.5840672Z ========================== Starting Command Output ===========================
2023-12-15T21:24:52.6013664Z ##[command]"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_work\_temp\63c6cceb-158e-4b5a-8b3c-1c81b7e9b335.cmd""
2023-12-15T21:24:52.7697768Z "C:\python3\python.exe" "D:\a\_work\1\s\src\tests\run.py" -arch x64 -build_type Release --run_nativeaot_tests -target_os windows
2023-12-15T21:24:53.3908776Z Error, incorrect test location.
2023-12-15T21:24:53.4457842Z ##[error]Cmd.exe exited with code '1'.
2023-12-15T21:24:53.4736446Z ##[section]Finishing: Run tests in single file mode
yowl commented 8 months ago

I suppose there is a new error now ?

jkotas commented 8 months ago

windows-x64 Release AllConfigurations - Prepare job-specific intermediate artifacts subdirectory is failing with:

2023-12-16T15:09:02.9005105Z ##[section]Starting: Prepare job-specific intermediate artifacts subdirectory
2023-12-16T15:09:02.9161604Z ==============================================================================
2023-12-16T15:09:02.9161743Z Task         : Copy files
2023-12-16T15:09:02.9161804Z Description  : Copy files from a source folder to a target folder using patterns matching file paths (not folder paths)
2023-12-16T15:09:02.9161927Z Version      : 2.231.1
2023-12-16T15:09:02.9161986Z Author       : Microsoft Corporation
2023-12-16T15:09:02.9162060Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/copy-files
2023-12-16T15:09:02.9162156Z ==============================================================================
2023-12-16T15:09:03.5919763Z ##[error]Error: Not found SourceFolder: D:\a\_work\1\s\artifacts\packages\Release
2023-12-16T15:09:03.6154257Z ##[section]Finishing: Prepare job-specific intermediate artifacts subdirectory

windows-x64 Release AllConfigurations did not run at all in the official builds before #2419. Do we need to run it? Should it be disabled again?

Last green official build: image

Current official build: image

yowl commented 8 months ago

Thanks

jkotas commented 8 months ago

After #2465, it is failing in Download IntermediateArtifacts when preparing the files for publishing.

2023-12-17T17:14:25.0014470Z ##[section]Starting: Download IntermediateArtifacts
2023-12-17T17:14:25.0093158Z ==============================================================================
2023-12-17T17:14:25.0093253Z Task         : Download build artifacts
2023-12-17T17:14:25.0093310Z Description  : Download files that were saved as artifacts of a completed build
2023-12-17T17:14:25.0093374Z Version      : 0.232.0
2023-12-17T17:14:25.0093419Z Author       : Microsoft Corporation
2023-12-17T17:14:25.0093468Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/download-build-artifacts
2023-12-17T17:14:25.0093542Z ==============================================================================
2023-12-17T17:14:25.5753428Z Downloading artifacts for build: 2337295
2023-12-17T17:14:25.7464765Z ##[error]Artifact IntermediateArtifacts not found for build 2337295. Please ensure you have published artifacts in any previous phases of the current build.
2023-12-17T17:14:25.7475753Z ##[section]Finishing: Download IntermediateArtifacts

The same log for last successful build looks like this:

2023-11-24T15:33:32.6802331Z ##[section]Starting: Download IntermediateArtifacts
2023-11-24T15:33:32.6885626Z ==============================================================================
2023-11-24T15:33:32.6885859Z Task         : Download build artifacts
2023-11-24T15:33:32.6886000Z Description  : Download files that were saved as artifacts of a completed build
2023-11-24T15:33:32.6886265Z Version      : 0.231.2
2023-11-24T15:33:32.6886343Z Author       : Microsoft Corporation
2023-11-24T15:33:32.6886473Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/download-build-artifacts
2023-11-24T15:33:32.6886825Z ==============================================================================
2023-11-24T15:33:33.2711599Z Downloading artifacts for build: 2322758
2023-11-24T15:33:33.4041972Z Downloading items from container resource #/15591274/IntermediateArtifacts
2023-11-24T15:33:33.4043518Z Downloading artifact IntermediateArtifacts from: https://dev.azure.com/dnceng//_apis/resources/Containers/15591274?itemPath=IntermediateArtifacts&isShallow=true&api-version=4.1-preview.4
2023-11-24T15:33:34.0726236Z Downloading IntermediateArtifacts/browser_wasm_win/Shipping/Microsoft.DotNet.ILCompiler.LLVM.9.0.0-alpha.1.23574.2.nupkg to D:\a\_work\1\s\artifacts\PackageDownload\IntermediateArtifacts\browser_wasm_win\Shipping\Microsoft.DotNet.ILCompiler.LLVM.9.0.0-alpha.1.23574.2.nupkg
2023-11-24T15:33:34.1080404Z Downloaded IntermediateArtifacts/browser_wasm_win/Shipping/Microsoft.DotNet.ILCompiler.LLVM.9.0.0-alpha.1.23574.2.nupkg to D:\a\_work\1\s\artifacts\PackageDownload\IntermediateArtifacts\browser_wasm_win\Shipping\Microsoft.DotNet.ILCompiler.LLVM.9.0.0-alpha.1.23574.2.nupkg
2023-11-24T15:33:34.1753705Z Downloading IntermediateArtifacts/browser_wasm_win/Shipping/Microsoft.DotNet.ILCompiler.LLVM.9.0.0-alpha.1.23574.2.symbols.nupkg to D:\a\_work\1\s\artifacts\PackageDownload\IntermediateArtifacts\browser_wasm_win\Shipping\Microsoft.DotNet.ILCompiler.LLVM.9.0.0-alpha.1.23574.2.symbols.nupkg
...

Current build:

image

Last successful build:

image

Do we need to add the Publish intermediate artifacts step back?

yowl commented 8 months ago

Seems likely, #2466 sets uploadIntermediateArtifacts equal to isOfficialBuild

jkotas commented 8 months ago

It finally succeeded. Do the packages look good?

yowl commented 8 months ago

Yes, thank you! Have also been tested over at https://github.com/bytecodealliance/wit-bindgen/pull/791