search

dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.38k stars 192 forks source link

[NativeAOT-LLVM] Official windows build does not build tests #2463

Closed yowl closed 8 months ago

yowl commented 8 months ago

This PR removes the Build tests step from the official windows build. My logic here is

  1. At https://github.com/dotnet/runtimelab/blob/c0547d1c13a46c2dee1be023e75c8eca0a0730e2/eng/pipelines/runtimelab.yml#L152 we need the libraries built

  2. That happens here https://github.com/dotnet/runtimelab/blob/c0547d1c13a46c2dee1be023e75c8eca0a0730e2/eng/pipelines/runtimelab.yml#L133 where only the subset libs is built

  3. Therefor we can't/shouldn't run the tests.

Incidentally why is runtimelab.yml included in the runtime repo?

jkotas commented 8 months ago

Incidentally why is runtimelab.yml included in the runtime repo?

I presume it is so that new runtimelab branches don't have to write their own CI from scratch.

Yes, that's correct.

yowl commented 8 months ago

Hopefully this will fix #2461