search

dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.38k stars 192 forks source link

Merge dec23 #2473

Closed yowl closed 7 months ago

yowl commented 7 months ago

This PR merges from upstream at commit ec2bfd78513d7240522b50b08c9d3455391b8f59.

Notable changes:

yowl commented 7 months ago

@pavelsavara @maraf Hi, I'm merging the latest from runtime, and have this error:

        MONO_WASM: postRunAsync
        MONO_WASM: added module imports 'main.js'
        Hello, DotnetJs!
        Args A, B, C
        MONO_WASM: Error
            at mono_exit (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.js:1804:24)
            at Object.onAbort (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.js:1781:5)
            at abort (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.native.js:668:22)
            at _mono_wasm_bind_js_function (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.native.js:6130:3)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_Interop_Runtime___BindJSImport_g____PInvoke_1_0 (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[8039]:0x71e33c)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_Interop_Runtime__BindJSImport (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[11764]:0xa107f4)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_Interop_Runtime__BindJSImport_0 (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[5973]:0x5481e0)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_System_Runtime_InteropServices_JavaScript_JSFunctionBinding__BindJSImportImpl (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[116
  23]:0x9ec9e0)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_System_Runtime_InteropServices_JavaScript_JSFunctionBinding__BindJSFunction (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[5906]
  :0x52f2b1)
            at dotnet.native.wasm.DotnetJs_DotnetJsApp_Program_Interop__Math (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[11571]:0x9ddfbe)
            at dotnet.native.wasm.DotnetJs_DotnetJsApp_Program__Main (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[5844]:0x52824d)
            at dotnet.native.wasm.DotnetJs__Module___MainMethodWrapper (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[5850]:0x528d9f)
            at dotnet.native.wasm.DotnetJs__Module___StartupCodeMain (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[15282]:0xd677a7)
            at dotnet.native.wasm.main (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[52]:0x124b2)
            at file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.native.js:738:14
            at Object.callMain (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.native.js:7544:15)
            at mono_run_main (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.runtime.js:16707:34)
            at file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/main.js:16:20

Any ideas what that could be?

maraf commented 7 months ago

@pavelsavara @maraf Hi, I'm merging the latest from runtime, and have this error:

        MONO_WASM: postRunAsync
        MONO_WASM: added module imports 'main.js'
        Hello, DotnetJs!
        Args A, B, C
        MONO_WASM: Error
            at mono_exit (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.js:1804:24)
            at Object.onAbort (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.js:1781:5)
            at abort (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.native.js:668:22)
            at _mono_wasm_bind_js_function (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.native.js:6130:3)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_Interop_Runtime___BindJSImport_g____PInvoke_1_0 (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[8039]:0x71e33c)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_Interop_Runtime__BindJSImport (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[11764]:0xa107f4)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_Interop_Runtime__BindJSImport_0 (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[5973]:0x5481e0)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_System_Runtime_InteropServices_JavaScript_JSFunctionBinding__BindJSImportImpl (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[116
  23]:0x9ec9e0)
            at dotnet.native.wasm.System_Runtime_InteropServices_JavaScript_System_Runtime_InteropServices_JavaScript_JSFunctionBinding__BindJSFunction (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[5906]
  :0x52f2b1)
            at dotnet.native.wasm.DotnetJs_DotnetJsApp_Program_Interop__Math (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[11571]:0x9ddfbe)
            at dotnet.native.wasm.DotnetJs_DotnetJsApp_Program__Main (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[5844]:0x52824d)
            at dotnet.native.wasm.DotnetJs__Module___MainMethodWrapper (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[5850]:0x528d9f)
            at dotnet.native.wasm.DotnetJs__Module___StartupCodeMain (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[15282]:0xd677a7)
            at dotnet.native.wasm.main (wasm://wasm/dotnet.native.wasm-075f84be:wasm-function[52]:0x124b2)
            at file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.native.js:738:14
            at Object.callMain (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.native.js:7544:15)
            at mono_run_main (file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/dotnet.runtime.js:16707:34)
            at file:///E:/GitHub/runtimelab/artifacts/tests/coreclr/browser.wasm.Debug/nativeaot/SmokeTests/DotnetJs/DotnetJs/native/main.js:16:20

Any ideas what that could be?

Hmm, JSImport binding failed, but I don't see the actual error message. I'll check it when I get to PC

yowl commented 7 months ago

Hmm, JSImport binding failed, but I don't see the actual error message. I'll check it when I get to PC

No problelm, think I found it, thanks.

yowl commented 7 months ago

cc @dotnet/nativeaot-llvm

pavelsavara commented 7 months ago

Hmm, JSImport binding failed, but I don't see the actual error message. I'll check it when I get to PC

No problelm, think I found it, thanks.

I'm actively working in that space and likely will break it again for you with my subsequent PRs. Apologies for that in advance.

yowl commented 7 months ago

I'm actively working in that space and likely will break it again for you with my subsequent PRs. Apologies for that in advance.

Thanks for the heads up.

yowl commented 7 months ago

Thanks, I'll wait for @MichalStrehovsky to see if he wants the PreInit changes upstreamed.

MichalStrehovsky commented 7 months ago

Thanks, I'll wait for @MichalStrehovsky to see if he wants the PreInit changes upstreamed.

Upstream sounds good. It will reduce the diffs to this branch and that's always nice. I would not block this pr on that, it should merge cleanly later.