dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.37k stars 189 forks source link

[NativeAOT-LLVM] Implement alternative for reachable block detection #2478

Closed yowl closed 2 months ago

yowl commented 6 months ago

We are currently reseting the bbIDom to detect reachable blocks

https://github.com/dotnet/runtimelab/blob/75e4231c4983020f2c1a75b80bb5bb0b111a0f4c/src/coreclr/jit/compiler.cpp#L5167

We could instead use m_dfsTree->Contains and then remove this code.

cc @SingleAccretion @jakobbotsch

SingleAccretion commented 2 months ago

Fixed in #2480.