search

dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.37k stars 189 forks source link

[NativeAOT-LLVM] Remove USE_SDL option as no longer needed #2483

Closed yowl closed 6 months ago

yowl commented 6 months ago

This small PR removes ths USE_SDL option as we have upgraded the emscripten version and updates a missed doc change for 8 -> 9

yowl commented 6 months ago

cc @dotnet/nativeaot-llvm

jkotas commented 6 months ago

Smoke tests are failing:

2024-01-11T03:29:04.5377315Z   "D:\a\_work\1\s\wasm-tools\node-v20.2.0-win-x64\node.exe" --stack-trace-limit=100 System.Collections.Specialized.Tests.js -notrait category=OuterLoop -notrait category=failing 
2024-01-11T03:29:04.9428896Z   D:\a\_work\1\s\artifacts\bin\System.Collections.Specialized.Tests\Release\net9.0\publish\System.Collections.Specialized.Tests.js:128
2024-01-11T03:29:04.9430985Z         throw ex;
2024-01-11T03:29:04.9431133Z         ^
2024-01-11T03:29:04.9431282Z   
2024-01-11T03:29:04.9431466Z   RuntimeError: memory access out of bounds
2024-01-11T03:29:04.9432276Z       at System.Collections.Specialized.Tests.wasm.S_P_CoreLib_System_Environment___cctor (wasm://wasm/System.Collections.Specialized.Tests.wasm-0eff111e:wasm-function[3782]:0x249480)
2024-01-11T03:29:04.9433090Z       at System.Collections.Specialized.Tests.wasm.S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__EnsureClassConstructorRun (wasm://wasm/System.Collections.Specialized.Tests.wasm-0eff111e:wasm-function[38161]:0x1d278e1)
2024-01-11T03:29:04.9434116Z       at System.Collections.Specialized.Tests.wasm.S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__CheckStaticClassConstructionReturnNonGCStaticBase (wasm://wasm/System.Collections.Specialized.Tests.wasm-0eff111e:wasm-function[3783]:0x2494c1)
2024-01-11T03:29:04.9434925Z       at System.Collections.Specialized.Tests.wasm.__GetGCStaticBase_S_P_CoreLib_System_Environment (wasm://wasm/System.Collections.Specialized.Tests.wasm-0eff111e:wasm-function[41246]:0x1ea9ad4)
2024-01-11T03:29:04.9435678Z       at System.Collections.Specialized.Tests.wasm.S_P_CoreLib_Internal_Runtime_CompilerHelpers_StartupCodeHelpers__InitializeCommandLineArgs (wasm://wasm/System.Collections.Specialized.Tests.wasm-0eff111e:wasm-function[3776]:0x248d98)
2024-01-11T03:29:04.9436398Z       at System.Collections.Specialized.Tests.wasm.System_Collections_Specialized_Tests__Module___StartupCodeMain (wasm://wasm/System.Collections.Specialized.Tests.wasm-0eff111e:wasm-function[36558]:0x1c19611)
2024-01-11T03:29:04.9436876Z       at System.Collections.Specialized.Tests.wasm.main (wasm://wasm/System.Collections.Specialized.Tests.wasm-0eff111e:wasm-function[58]:0x2973c)
jkotas commented 6 months ago

Failure is known issue.

jkotas commented 6 months ago

Thank you!

yowl commented 6 months ago

ah ok, thanks, I tried windows/debug locally and it didn't reproduce.