search

dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.41k stars 197 forks source link

Add new official build for runtimelab #2563

Closed agocke closed 5 months ago

agocke commented 5 months ago

This brings in the same 1ES official build templates that are in runtime and are now required for all internal builds.

agocke commented 5 months ago

FYI for msft employees, internal run ID is 2438214

jkotas commented 5 months ago

internal run ID is 2438214

Succeeded, but it did not publish the packages (e.g. https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-experimental/NuGet/runtime.browser-wasm.Microsoft.DotNet.ILCompiler.LLVM/)

agocke commented 5 months ago

internal run ID is 2438214

Succeeded, but it did not publish the packages (e.g. https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-experimental/NuGet/runtime.browser-wasm.Microsoft.DotNet.ILCompiler.LLVM/)

Yup, expected -- it's branch gated so we won't get any new packages until this is merged.

agocke commented 5 months ago

What is it exactly that is required of the "official" .yml (that wasn't previously)?

In short, we need to import an internal template that sets policy.

Is it required to have a separate .yml instead of using runtimelab.yml with isOfficialBuild: true, or is it a code organization choice?

It's possible to share, but hard. The internal template requires certain tasks to be used, and those tasks aren't available in the public template. The current guidance is to split to internal and external.

Can/should we delete isOfficialBuild == true paths from runtimelab.yml now (downstream and upstream)?

Yes, although that's not strictly necessary.

jkotas commented 5 months ago

Also build tests in official build

I do not think we should be doing that. It makes official build flakier and the failures in official build are impossible for non-Microsoft people to see and debug.

agocke commented 5 months ago

The current config is running tests, so I can instead just skip testing entirely.

jkotas commented 5 months ago

skip testing entirely.

Yes, that would be better.

yowl commented 5 months ago

The current config is running tests, so I can instead just skip testing entirely.

Sorry, my mistake.

agocke commented 5 months ago

np, simple change. Looks like the internal build passed.

jkotas commented 5 months ago

I am assuming a version of this will go upstream. Is that correct?

https://github.com/dotnet/runtime/pull/101655