search

dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.36k stars 188 forks source link

delete unused LegacyObjectWriter #2564

Closed kasperk81 closed 2 months ago

kasperk81 commented 2 months ago

deleted in https://github.com/dotnet/runtimelab/commit/5961ee18301a8bf63995ea4031c0e5efe63c8795

kasperk81 commented 2 months ago

if LLVMObjectWriter can be derived from new base ObjectWriter it can be moved in this directory.

@SingleAccretion (i can see it's not the goal of this project, but in theory) can ilcompiler write wasm object directly with WasmObjextWriter or is it too massive of a project?

SingleAccretion commented 2 months ago

can ilcompiler write wasm object directly with WasmObjextWriter or is it too massive of a project?

It certainly can. https://github.com/dotnet/runtimelab/issues/2404 is an issue where that would be something required to get the functionality we want.

However, a WASM-specific object writer would subtract from the goal of producing more-or-less portable bitcode. I have been thinking about using an approach like the old LLVM object writer instead, but with a text interface (i. e. produce .S files), which would be more portable (but not as portable as bitcode, obviously). Nothing as yet has been decided here, however. The approach in #2404 has problems beside needing a different object writer (namely, it doesn't work well with post-link optimizers).