search

dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.36k stars 188 forks source link

[NativeAOT-LLVM] Build on Linux #2574

Closed yowl closed 1 month ago

yowl commented 2 months ago

This PR reenables the build of the product on Linux, including the LLVM JIT. Does not build the Wasm runtime or libraries on Linux (to be done in #2569 )

Fixes #1713

yowl commented 1 month ago

cc @dotnet/nativeaot-llvm

yowl commented 1 month ago

Lots of little commits, but think that's all the comments above addressed.

yowl commented 1 month ago

"But the only uses of host_arch that I see look to be new (added in this change). My suggestion is delete them - or are they needed for something?"

You are right, I don't actually need it here, but I will for ./build.sh clr.aot -c Debug -a wasm -os browser

SingleAccretion commented 1 month ago

My preference would be introduce them in the WASM change. In general, it looks unexpected to me that we need to change eng/common/build.sh, since these scripts are used upstream for -a wasm -os browser builds too.

yowl commented 1 month ago

My preference would be introduce them in the WASM change. In general, it looks unexpected to me that we need to change eng/common/build.sh, since these scripts are used upstream for -a wasm -os browser builds too.

OK, removed here.

yowl commented 1 month ago

Was on a break last week, so did this with lots of trail and error, but have now rebased to remove that noise and is green.