dotnet / runtimelab

This repo is for experimentation and exploring new ideas that may or may not make it into the main dotnet/runtime repo.
MIT License
1.36k stars 188 forks source link

Standalone template .runsettings generation up to date checks missing inputs #309

Open jkoritzinsky opened 3 years ago

jkoritzinsky commented 3 years ago

The up to date checks for generating the .runsettings file do not include checking that the $(TargetPlatform) or $(DotNetTool) are up to date. When switching between possibly using a globally installed runtime and a locally installed runtime, the generated file will keep the first-run option, which caused a lot of confusion and about an hour of wasted time trying to figure out what happened.

https://github.com/dotnet/runtimelab/blob/b1095c5e91f22fa8ffa925a2938f35fd6579e611/eng/testing/runsettings.targets#L16-L17

safern commented 3 years ago

Makes sense... will fix that