dotnet / samples

Sample code referenced by the .NET documentation
https://docs.microsoft.com/samples/browse
Creative Commons Attribution 4.0 International
3.42k stars 5.09k forks source link

The root .editorConfig is missing VB configuration #1896

Open paul1956 opened 4 years ago

paul1956 commented 4 years ago

Before you open an issue

If the issue is:

Issue description The .EditorConfig file only has limited formatting rules for VB only below

[*.{cs,vb}]
charset = utf-8-bom
[*.vb]
# Modifier preferences
visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public,Friend,NotOverridable,Overridable,MustOverride,Overloads,Overrides,MustInherit,NotInheritable,Static,Shared,Shadows,ReadOnly,WriteOnly,Dim,Const,WithEvents,Widening,Narrowing,Custom,Async:suggestion

Target framework N/A Check the .NET target framework(s) being used, and include the version number(s).

If using the .NET Core SDK, include dotnet --info output. If using .NET Framework without the .NET Core SDK, include info from Visual Studio's Help > About Microsoft Visual Studio dialog.

All the require style for VB samples is missing dotnet --info output or About VS info ```console ```
Youssef1313 commented 4 years ago

Does PR #1895 fix that ?

paul1956 commented 4 years ago

Looks very good maybe perfect. My only question is some of the options use C# terms like static or internal where VB uses Shared and Friend and those options are available in .editorConfig. Does something internal do the translation so that the shared setting work with both VB and C#, trying it out I seem to get the desired result in VB or at least get no suggestions.