search

dotnet / scenario-tests

Scenario testing for installed .NET Core SDKs
MIT License
5 stars 7 forks source link

[main] Update dependencies from dotnet/arcade #78

Closed dotnet-maestro[bot] closed 1 month ago

dotnet-maestro[bot] commented 5 months ago

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

mmitche commented 3 months ago

@joperezr The aspire workload tests here are failing due to unsigned packages:

EXEC : error : NU3004: The package is not signed. [D:\a\1\s\src\Microsoft.DotNet.ScenarioTests.SdkTemplateTests\Microsoft.DotNet.ScenarioTests.SdkTemplateTests.csproj]

When running these type of tests, should the SDK not be verifying package signing?

ViktorHofer commented 2 months ago

gentle ping @joperezr

ViktorHofer commented 1 month ago

@joperezr please take a look

mmitche commented 1 month ago

@RussKie can you take a look while @joperezr is out?

RussKie commented 1 month ago

@radical are you familiar with these failing tests?

radical commented 1 month ago

@radical are you familiar with these failing tests?

nope, sorry!

joperezr commented 1 month ago

The error this is hitting is an issue with the SDK that has been fixed (worked around) in Aspire 8.0.1 and later versions, but this hasn't shipped in a newer SDK. @marcpopMSFT @dsplaisted has the fix for the duplicate workload entry concurrency issue been shipped in the SDK yet? If so we can probably just bump the global.json SDK version to unblock this PR.

marcpopMSFT commented 1 month ago

The error this is hitting is an issue with the SDK that has been fixed (worked around) in Aspire 8.0.1 and later versions, but this hasn't shipped in a newer SDK. @marcpopMSFT @dsplaisted has the fix for the duplicate workload entry concurrency issue been shipped in the SDK yet? If so we can probably just bump the global.json SDK version to unblock this PR.

We never actually tracked down the issue as it was a multi-threading problem in the template engine that was only being triggered by Aspire. So once Aspire fixed it, we didn't keep digging (though vendors just found a new case of it we think but it requires automated template creation).

dsplaisted commented 1 month ago

We never actually tracked down the issue as it was a multi-threading problem in the template engine that was only being triggered by Aspire. So once Aspire fixed it, we didn't keep digging (though vendors just found a new case of it we think but it requires automated template creation).

We did actually figure out the details of why this was happening: https://github.com/dotnet/templating/issues/7946#issuecomment-2108853692. However, it wasn't clear how to fix it correctly without impacting template engine perf, so it hasn't been fixed yet.

marcpopMSFT commented 1 month ago

We did actually figure out the details of why this was happening: dotnet/templating#7946 (comment). However, it wasn't clear how to fix it correctly without impacting template engine perf, so it hasn't been fixed yet.

Good point, my memory failed me.

akoeplinger commented 1 month ago

So what should we do? Disable the VerifyAspireTemplate test to unblock this PR?

mmitche commented 1 month ago

So what should we do? Disable the VerifyAspireTemplate test to unblock this PR?

That would be my preference.

akoeplinger commented 1 month ago

@mmitche disabled the test and it's green now. I don't have permission to merge here though.