Closed dotnet-maestro[bot] closed 1 month ago
@joperezr The aspire workload tests here are failing due to unsigned packages:
EXEC : error : NU3004: The package is not signed. [D:\a\1\s\src\Microsoft.DotNet.ScenarioTests.SdkTemplateTests\Microsoft.DotNet.ScenarioTests.SdkTemplateTests.csproj]
When running these type of tests, should the SDK not be verifying package signing?
gentle ping @joperezr
@joperezr please take a look
@RussKie can you take a look while @joperezr is out?
@radical are you familiar with these failing tests?
@radical are you familiar with these failing tests?
nope, sorry!
The error this is hitting is an issue with the SDK that has been fixed (worked around) in Aspire 8.0.1 and later versions, but this hasn't shipped in a newer SDK. @marcpopMSFT @dsplaisted has the fix for the duplicate workload entry concurrency issue been shipped in the SDK yet? If so we can probably just bump the global.json SDK version to unblock this PR.
The error this is hitting is an issue with the SDK that has been fixed (worked around) in Aspire 8.0.1 and later versions, but this hasn't shipped in a newer SDK. @marcpopMSFT @dsplaisted has the fix for the duplicate workload entry concurrency issue been shipped in the SDK yet? If so we can probably just bump the global.json SDK version to unblock this PR.
We never actually tracked down the issue as it was a multi-threading problem in the template engine that was only being triggered by Aspire. So once Aspire fixed it, we didn't keep digging (though vendors just found a new case of it we think but it requires automated template creation).
We never actually tracked down the issue as it was a multi-threading problem in the template engine that was only being triggered by Aspire. So once Aspire fixed it, we didn't keep digging (though vendors just found a new case of it we think but it requires automated template creation).
We did actually figure out the details of why this was happening: https://github.com/dotnet/templating/issues/7946#issuecomment-2108853692. However, it wasn't clear how to fix it correctly without impacting template engine perf, so it hasn't been fixed yet.
We did actually figure out the details of why this was happening: dotnet/templating#7946 (comment). However, it wasn't clear how to fix it correctly without impacting template engine perf, so it hasn't been fixed yet.
Good point, my memory failed me.
So what should we do? Disable the VerifyAspireTemplate
test to unblock this PR?
So what should we do? Disable the
VerifyAspireTemplate
test to unblock this PR?
That would be my preference.
@mmitche disabled the test and it's green now. I don't have permission to merge here though.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Subscription: 69ccaae5-538f-448b-d9ab-08db87e0b330
Build: 20240718.9
Date Produced: July 18, 2024 4:59:11 PM UTC
Commit: b4e499d1f6e6b3a981feabfed290d99261762382
Branch: refs/heads/main
Updates: