dotnet / sdk-container-builds

Libraries and build tooling to create container images from .NET projects using MSBuild
https://learn.microsoft.com/en-us/dotnet/core/docker/publish-as-container
MIT License
179 stars 34 forks source link

Container builds no longer work with Preview 7 #485

Closed richlander closed 11 months ago

richlander commented 1 year ago

I installed Preview 7. I was trying to validate if https://github.com/dotnet/sdk-container-builds/issues/479 is resolved.

I now need to specify ContainerBaseImage to make it work.

I am building this app: https://github.com/richlander/dotnet-docker/tree/dotnet-8-samples/samples/aspnetapp/aspnetapp

$ pwd
/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp
 $ dotnet publish /p:PublishProfile=DefaultContainer
MSBuild version 17.8.0-preview-23367-03+0ff2a83e9 for .NET
  Determining projects to restore...
  Restored /Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj (in 577 ms).
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(314,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
  aspnetapp -> /Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/bin/Release/net8.0/aspnetapp.dll
  aspnetapp -> /Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/bin/Release/net8.0/publish/
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Containers/build/Microsoft.NET.Build.Containers.targets(201,5): error MSB4018: The "CreateNewImage" task failed unexpectedly. [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Containers/build/Microsoft.NET.Build.Containers.targets(201,5): error MSB4018: System.Net.Http.HttpRequestException: Response status code does not indicate success: 404 (Not Found). [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Containers/build/Microsoft.NET.Build.Containers.targets(201,5): error MSB4018:    at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode() [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Containers/build/Microsoft.NET.Build.Containers.targets(201,5): error MSB4018:    at Microsoft.NET.Build.Containers.DefaultManifestOperations.GetAsync(String repositoryName, String reference, CancellationToken cancellationToken) in /_/src/Containers/Microsoft.NET.Build.Containers/Registry/DefaultManifestOperations.cs:line 30 [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Containers/build/Microsoft.NET.Build.Containers.targets(201,5): error MSB4018:    at Microsoft.NET.Build.Containers.Registry.GetImageManifestAsync(String repositoryName, String reference, String runtimeIdentifier, String runtimeIdentifierGraphPath, CancellationToken cancellationToken) in /_/src/Containers/Microsoft.NET.Build.Containers/Registry/Registry.cs:line 110 [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Containers/build/Microsoft.NET.Build.Containers.targets(201,5): error MSB4018:    at Microsoft.NET.Build.Containers.Tasks.CreateNewImage.ExecuteAsync(CancellationToken cancellationToken) in /_/src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs:line 61 [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Containers/build/Microsoft.NET.Build.Containers.targets(201,5): error MSB4018:    at Microsoft.NET.Build.Containers.Tasks.CreateNewImage.Execute() in /_/src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs:line 35 [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Containers/build/Microsoft.NET.Build.Containers.targets(201,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Containers/build/Microsoft.NET.Build.Containers.targets(201,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]

And then if I do, the user is no longer set.

 dotnet publish /p:PublishProfile=DefaultContainer /p:ContainerBaseImage=mcr.microsoft.com/dotnet/aspnet:8.0-preview-jammy
MSBuild version 17.8.0-preview-23367-03+0ff2a83e9 for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
/usr/local/share/dotnet/sdk/8.0.100-preview.7.23376.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(314,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
  aspnetapp -> /Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/bin/Release/net8.0/aspnetapp.dll
  aspnetapp -> /Users/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/bin/Release/net8.0/publish/
  Building image 'aspnetapp' with tags latest on top of base image mcr.microsoft.com/dotnet/aspnet:8.0-preview-jammy
  Pushed image 'aspnetapp:latest' to local registry
$ docker inspect aspnetapp | grep User
            "User": "",
            "User": "",
baronfel commented 1 year ago

Can you send a binlog? I couldn't replicate on a self-built SDK from the tip of the 8.0.100-preview7 release branch - I built that app using the same command and the generated manifest had the 1654 user. I'll try again with the latest 7 nightly from dotnet/installer in a bit.

baronfel commented 11 months ago

Closing as no repro.