search

dotnet / sdk-container-builds

Libraries and build tooling to create container images from .NET projects using MSBuild
https://learn.microsoft.com/en-us/dotnet/core/docker/publish-as-container
MIT License
176 stars 30 forks source link

Clean up some messy stack traces #515

Closed baronfel closed 5 months ago

baronfel commented 8 months ago

There are a few scenarios where we don't exit cleanly here:

We should provide better handling for these two scenarios, and we should provide a configuration knob for the HTTP timeout - something like SDK_CONTAINER_HTTP_TIMEOUT_SECONDS to allow users to override this. When we add it we should make sure the error message for HttpClient timeouts calls out the new environment variable.

baronfel commented 5 months ago

We've done the first part of this in 8.0.200, and the second part is captured in https://github.com/dotnet/sdk-container-builds/issues/543, so closing this issue.