search

dotnet / sdk-container-builds

Libraries and build tooling to create container images from .NET projects using MSBuild
https://learn.microsoft.com/en-us/dotnet/core/docker/publish-as-container
MIT License
175 stars 30 forks source link

Container inferencing for AOT can move to stable repo #555

Closed richlander closed 3 months ago

richlander commented 4 months ago

For container publishing with PublishAot (for a .NET 8 app), I see:

$ dotnet publish /t:PublishContainer
MSBuild version 17.9.4+90725d08d for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
  hello-dotnet -> /home/rich/hello-dotnet/bin/Release/net8.0/linux-x64/hello-dotnet.dll
  Generating native code
  hello-dotnet -> /home/rich/hello-dotnet/bin/Release/net8.0/linux-x64/publish/
  Building image 'hello-chiseled-aot' with tags 'latest' on top of base image 'mcr.microsoft.com/dotnet/nightly/runtime-deps:8.0-jammy-chiseled-extra'.
  Pushed image 'hello-chiseled-aot:latest' to local registry via 'docker'.

In the "use ICU" case, the following image can be used: mcr.microsoft.com/dotnet/runtime-deps:8.0-jammy-chiseled-extra

In the invariant case, then the nightly AOT image remains correct.

This change can go into servicing. If it breaks anyone, we have other problems.

The non-nightly images and 8.0.200 arrived at around the same time, hence the timing. This is fine to patch after-the-fact.

dotnet-issue-labeler[bot] commented 4 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

baronfel commented 4 months ago

Confirming - this is the case for both jammy-chiseled-extra and alpine-extra, but not jammy-chiseled-aot and alpine-aot?

richlander commented 3 months ago

This is just something extra for our customers.

baronfel commented 3 months ago

I got this approved in Tactics today - it'll go with next months SDK