Open MarkKharitonov opened 5 years ago
Please, see https://stackoverflow.com/questions/54033254/msbuild-and-dotnet-load-different-versions-of-sdk-targets EDIT 3 for a sample build output.
I think this might be a MSBuild issue.
Distributed loggers appear to default to showing summary. We use a distributed logger for telemetry in the CLI. However, SetForwardingBasedOnVerbosity
should probably calculate _showSummary
based on the verbosity level (which is quiet in this case) instead of defaulting to true
.
Ping @rainersigwald to comment.
Edit: the above is an uneducated guess and I'm fairly unfamiliar with the MSBuild source 😄
Red herring, as:
dotnet exec "c:\Program Files\dotnet\sdk\3.0.100-preview-009793\MSBuild.dll" -v:q "-distributedlogger:Microsoft.DotNet.Tools.MSBuild.MSBuildLogger,C:\Program Files\dotnet\sdk\3.0.100-preview-009793\dotnet.dll*Microsoft.DotNet.Tools.MSBuild.MSBuildForwardingLogger,C:\Program Files\dotnet\sdk\3.0.100-preview-009793\dotnet.dll"
Doesn't show the summary, so there must be something else causing it.
Sorry for the ping, @rainersigwald. It looks like the build command itself is forcing the summary:
Thus the fix is entirely on the CLI side.
Hi @peterhuene,
Can you assign this issue to me. I can try this as my first issue.
@theswanand done! Thanks for the interest and the help!
Hi, Can anyone advice me the project name to simulate/fix this issue. As documented in Readme, the code has been moved to dotnet/toolset. But I am unable to build it as well. So should I need to try dotnet/sdk or I am missing something over here.
Is this issue still active?
Just checked for 16.4.0+e901037fe - still there.
Hi @livarcocc , I tried simulating this on .NET 5.0 preview version and got below output
F:\Repos\sdk\src\Microsoft.DotNet.MSBuildSdkResolver>dotnet build /v:q
Microsoft (R) Build Engine version 16.6.0-preview-20126-02+13cfe7fc5 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:04.06
So by
only the MSBUILD logo should be displayed
are we expecting the output to be like this:
F:\Repos\sdk\src\Microsoft.DotNet.MSBuildSdkResolver>dotnet build /v:q
Microsoft (R) Build Engine version 16.6.0-preview-20126-02+13cfe7fc5 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.
Are my assumptions correct? I will start working on this.
I confirm the issue is still there (.Net 5 Release) and it is pretty annoying :)
Hi,
I can see this similar issue(https://github.com/dotnet/sdk/issues/7986) where it was closed by @rainersigwald with below comments.
https://github.com/dotnet/sdk/issues/7986#issuecomment-604959822
For those looking for a workaround, as noted in the comment from ^
-v:quiet -consoleLoggerParameters:NoSummary
is actually quiet.
Hello, Is this still available?
We should re-evaluate if this is even required anymore. Terminal Logger is the default, and it is actually quiet when -v:q
is passed.
We should re-evaluate if this is even required anymore. Terminal Logger is the default, and it is actually quiet when
-v:q
is passed.
$ dotnet build /v:q test.csproj
Restore complete (0.0s)
Build succeeded in 0.0s
Workload updates are available. Run `dotnet workload list` for more information.
vs
$ dotnet build /v:q test.csproj --tl:off
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:00.05
Workload updates are available. Run `dotnet workload list` for more information.
so 3 fewer lines (5 vs 8 lines).
$ dotnet --version
9.0.100-preview.3.24153.2
One of those lines (in both cases) comes from the SDK itself - I think you would need to set an environment variable to disable workload manifest update advertisements in that case.
@rainersigwald seeing that console logger has a parameter for no summary, should TL learn one as well?
Hm, or should it just be implied by a successful /v:q
?
Steps to reproduce
dotnet build /v:q
Expected behavior
Only the msbuild logo is displayed
Actual behavior
Additional lines are displayed:
Environment data