search

dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI
https://dot.net/core
MIT License
2.73k stars 1.07k forks source link

[loc][Query][sdk] Localizability of strings #12166

Open PDostalek opened 4 years ago

PDostalek commented 4 years ago

Hi, please help localization team to answer question from translator. In case translator is not sure about context/meaning/localizability of string we raise a question.

Id File Name Live Page Extended String Resource ID Full Source String Extended Description Answer Needed By
50306 Cli\dotnet\commands\dotnet-test\xlf\LocalizableStrings.xlf 0; "CmdBlameHangTimeoutDescription" Per-test timeout, after which hang dump is triggered and the testhost process is terminated. \r\nThe timeout value is specified in the following format: 1.5h / 90m / 5400s / 5400000ms. When no unit is used (e.g. 5400000), the value is assumed to be in milliseconds.\r\nWhen used together with data driven tests, the timeout behavior depends on the test adapter used. For xUnit and NUnit the timeout is renewed after every test case,\r\nFor MSTest, the timeout is used for all testcases.\r\nThis option is currently supported only on Windows together with netcoreapp2.1 and newer. And on Linux with netcoreapp3.1 and newer. OSX and UWP are not supported. In the sample format (1.5h, 90m, 5400ms), should h, m, and ms be translated? Or should they be specified literal?  
dsplaisted commented 3 years ago

@nohwnd @jakubch1 Can you answer or route this? The command line argument in question is piped through to the VSTestBlameHangTimeout property.

nohwnd commented 3 years ago

@PDostalek what is the question?

marcpopMSFT commented 2 years ago

@cristianosuzuki77 is this still relevant?

KalleOlaviNiemitalo commented 2 years ago

VSTest appears to parse the timeout with a regex in which the suffixes are not localised. (The number is parsed to Double using CurrentCulture but the regex does not allow it to contain a comma; so if you want to specify ten and a half seconds and your culture requires a comma, then I think neither "10.5s" nor "10,5s" works, but "10500ms" is a workaround.)

https://github.com/microsoft/vstest/blob/b2e2126f1aa7e5753cafe9515563c99ade6a59ce/src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs#L269-L272

https://github.com/microsoft/vstest/blob/70b83117ae7e1a0352764dd11fe31eba84200f27/src/vstest.console/Processors/EnableBlameArgumentProcessor.cs#L231-L233

https://github.com/microsoft/vstest/blob/70b83117ae7e1a0352764dd11fe31eba84200f27/src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Constants.cs#L96

https://github.com/microsoft/vstest/blob/70b83117ae7e1a0352764dd11fe31eba84200f27/src/Microsoft.TestPlatform.Extensions.BlameDataCollector/BlameCollector.cs#L397-L399

https://github.com/microsoft/vstest/blob/ff16d342e86091138ee5630002d874e33cb48278/src/Microsoft.TestPlatform.CoreUtilities/Utilities/TimeSpanParser.cs#L11