dotnet / sdk

Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI
https://dot.net/core
MIT License
2.59k stars 1.03k forks source link

Merge installer repo into SDK #24415

Open marcpopMSFT opened 2 years ago

marcpopMSFT commented 2 years ago

Updating as we're doing an initial review of this work for potentially being done it .net 9.

Other scenarios to consider • Installer download page and feed list • Loc build from release branch for SDK and main branch for installer • CPM enabled in SDK • Dependabot and fabric bot in SDK • Workloads are overwritten in the SDK repo (overlaysdkonlkg.targets) • How would this affect stage0 updates and TFM updates? • How does this merge impact SB and VMR? • SDK repo reruns tests, installer repo reruns builds

For local dev build time, I think we need installer to not do it's crossgen build during the plain build. That increases the build time by nearly 2 minutes and if merged into SDK, would be too much to take on. Only do this build during build -pack

dotnet-issue-labeler[bot] commented 2 years ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

kasperk81 commented 11 months ago

update process is:

  1. runtime, aspnetcore, and x other repositories push their changes to sdk
  2. sdk makes a build and pushes to installer
  3. installer publishes the daily build

what would be the new process like: "2. sdk publishes the daily build" without step 3 for each successful pr merge?

@mmitche, @mthalman, @MichaelSimons, @lewing, thoughts? it was meant to improve the quality of life of persons investigating issues during sdk to installer updates and, of course, the frequency of daily builds.

mmitche commented 10 months ago

Yes, there would be no step 3 with these improvements.

kasperk81 commented 1 month ago

this is completed?

MiYanni commented 1 month ago

I've updated the tasks in the description.